Skip to content

Commit

Permalink
OCM-9780 | test: automated id:65900,id:76481 install with use-local-c…
Browse files Browse the repository at this point in the history
…redentials will work
  • Loading branch information
jerichokeyne committed Sep 25, 2024
1 parent 792d558 commit 6b01ca4
Show file tree
Hide file tree
Showing 5 changed files with 55 additions and 2 deletions.
29 changes: 28 additions & 1 deletion tests/ci/data/profiles/rosa-classic.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -214,4 +214,31 @@ profiles:
oidc_config: ""
shared_vpc: false
imdsv2: "optional"
admin_enabled: false
admin_enabled: false
- as: rosa-non-sts-local-creds
version: latest
channel_group: candidate
region: "us-east-1"
cluster:
multi_az: true
instance_type: ""
hcp: false
sts: false
byo_vpc: false
private_link: false
private: false
etcd_encryption: false
autoscale: false
kms_key: false
networking: false
proxy_enabled: false
label_enabled: false
zones: "us-east-1a,us-east-1b,us-east-1c"
tag_enabled: false
etcd_kms: false
fips: false
oidc_config: ""
shared_vpc: false
imdsv2: "optional"
admin_enabled: true
use_local_credentials: true
13 changes: 13 additions & 0 deletions tests/e2e/test_rosacli_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -1280,6 +1280,19 @@ var _ = Describe("Classic cluster creation validation",
Expect(errorOutput.String()).To(ContainSubstring("etcd encryption cannot be disabled on clusters with FIPS mode"))
})

It("validate use-local-credentials won't work with sts - [id:76481]",
labels.Medium, labels.Runtime.Day1Negative,
func() {
clusterName := "ocp-76481"

By("Create cluster with use-local-credentials flag but with sts")
errorOutput, err := clusterService.CreateDryRun(
clusterName, "--use-local-credentials", "--sts", "--mode=auto", "-y",
)
Expect(err).NotTo(BeNil())
Expect(errorOutput.String()).To(ContainSubstring("Local credentials are not supported for STS clusters"))
})

It("Create rosa cluster with additional security groups will validate well via rosacli - [id:68971]",
labels.Medium, labels.Runtime.Day1Negative,
func() {
Expand Down
9 changes: 8 additions & 1 deletion tests/e2e/test_rosacli_cluster_post.go
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,14 @@ var _ = Describe("Healthy check",
}

})

It("with use-local-credentials will work - [id:65900]", labels.Runtime.Day1Post, labels.High,
func() {
By("Check that the cluster was installed with the right profile")
jsonData, err := clusterService.GetJSONClusterDescription(clusterID)
Expect(jsonData.DigBool("properties", "use_local_credentials")).To(Equal(profile.ClusterConfig.UseLocalCredentials))
Expect(err).ToNot(HaveOccurred())
Expect(jsonData.DigBool("properties", "use_local_credentials")).To(BeTrue())
})
It("with proxy set will work - [id:45502]", labels.Runtime.Day1Post, labels.Critical,
func() {
By("Check the help message of proxy")
Expand Down
1 change: 1 addition & 0 deletions tests/utils/profilehandler/interface.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ type ClusterConfig struct {
SharedVPC bool `yaml:"shared_vpc,omitempty" json:"shared_vpc,omitempty"`
TagEnabled bool `yaml:"tag_enabled,omitempty" json:"tag_enabled,omitempty"`
NetworkType string `yaml:"network_type,omitempty" json:"network_type,omitempty"`
UseLocalCredentials bool `yaml:"use_local_credentials,omitempty" json:"use_local_credentials,omitempty"`
}

// UserData will record the user data prepared for resource clean up
Expand Down
5 changes: 5 additions & 0 deletions tests/utils/profilehandler/profile_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,11 @@ func GenerateClusterCreateFlags(profile *Profile, client *rosacli.Client) ([]str
"--domain-prefix", helper.TrimNameByLength(clusterName, ocm.MaxClusterDomainPrefixLength),
)
}
if profile.ClusterConfig.UseLocalCredentials {
flags = append(flags,
"--use-local-credentials",
)
}
if profile.ClusterConfig.STS {
var accRoles *rosacli.AccountRolesUnit
var oidcConfigID string
Expand Down

0 comments on commit 6b01ca4

Please sign in to comment.