Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CLI plugins in oc #15717

Merged
merged 4 commits into from
Aug 26, 2017
Merged

Enable CLI plugins in oc #15717

merged 4 commits into from
Aug 26, 2017

Conversation

fabianofranz
Copy link
Member

Trello story: https://trello.com/c/o6UiTkxv

Adds support to CLI plugins under the oc plugin command. Basically the same functionality and same subcommand already present upstream.

This is required for enabling the service catalog commands under oc, which will be distributed as plugins.

@liggitt one upstream commit for a feature that didn't make the 1.7 cut upstream
@openshift/cli-review @smarterclayton prease review
@sspeiche @pmorie FYI

@openshift-merge-robot openshift-merge-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 9, 2017
@bparees
Copy link
Contributor

bparees commented Aug 9, 2017

/unassign

@openshift-merge-robot openshift-merge-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 9, 2017
@fabianofranz
Copy link
Member Author

/retest

@juanvallejo
Copy link
Contributor

flaked on #8571
/retest

@jim-minter
Copy link
Contributor

jim-minter commented Aug 10, 2017 •
edited
Loading

sorry, I don't know why this was assigned to me or how I can help with it
/unassign

@jim-minter jim-minter removed their assignment Aug 10, 2017
@danwinship
Copy link
Contributor

sorry, I don't know why this was assigned to me or how I can help with it

yeah, likewise. (well, I know it was assigned to me because this includes tests and i'm listed as an approver in some subdirs of test/, but that seems like a bug in the assigning mechanism)

/unassign

@fabianofranz
Copy link
Member Author

/assign @juanvallejo @liggitt @smarterclayton

juanvallejo
juanvallejo reviewed Aug 15, 2017
View reviewed changes
vendor/k8s.io/kubernetes/pkg/kubectl/plugins/plugins.go
@@ -71,3 +81,33 @@ func (p Plugin) IsValid() bool {

// Plugins is a list of plugins.
type Plugins []*Plugin

// Flag describes a single flag supported by a given plugin.
type Flag struct {
Copy link
Contributor

@juanvallejo juanvallejo Aug 15, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabianofranz would it be worth having an interface for this and for Plugin?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't think of any use case where there would be different implementations of these guys, so I don't think it's worth at the moment. ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

@juanvallejo
Copy link
Contributor

One minor comment, but otherwise this lgtm from a cli perspective

@fabianofranz
Copy link
Member Author

@smarterclayton @liggitt UP

@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianofranz, smarterclayton

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2017
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

@fabianofranz: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce 607f80b link /test extended_conformance_gce
ci/openshift-jenkins/extended_conformance_install_update 607f80b link /test extended_conformance_install_update

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 15717, 15947)

@openshift-merge-robot openshift-merge-robot merged commit 020fe35 into openshift:master Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanvallejo juanvallejo juanvallejo left review comments

Assignees

@liggitt liggitt

@smarterclayton smarterclayton

@juanvallejo juanvallejo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@fabianofranz @bparees @juanvallejo @jim-minter @danwinship @smarterclayton @openshift-merge-robot @openshift-ci-robot @liggitt