-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reconcile cluster roles instead of overwriting #15654
reconcile cluster roles instead of overwriting #15654
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, enj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
failure is real |
@enj added a new commit if you want a second look. namespaced roles in our openshift namespace. Falls out like the other namespaced ones in the RBAC refactor. |
e0c3469
to
89a6220
Compare
LGTM |
/test end_to_end |
/retest |
yum problem |
#8571 |
/retest |
/test extended_conformance_install_update |
/retest Please review the full test history for this PR and help us cut down flakes. |
/test extended_conformance_install_update |
/retest |
1 similar comment
/retest |
Automatic merge from submit-queue |
fixes #15648
Moving to post-start hooks introduced a policy creation race. This pull fixes the race by unconditionally reconciling like we will in 3.7 when we switch to RBAC. I also made the reconcile cluster roles respect the annotation we use to protect the resources from reconciliation.
@openshift/security fyi