Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ubi instead of scratch #894

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jianzhangbjz
Copy link
Contributor

I'm not sure if I should modify the downstream directly, but some users have conerns when using the scratch, especially when building the multi-arch image. They have to modify the Dockfile after opm alpha bundle generate xxx. They will get an error if they forget to update the base image. So, I just submitted this PR, any comments are welcome! Thanks!

[yapei@yapei-mac apicast (operators)]$ opm alpha bundle validate --tag quay.io/yapei/apicast-operators-bundle:latest --image-builder podman
Command "validate" is deprecated, This subcommand is deprecated and will be removed in a future release. Migrate to operator-sdk bundle validate
INFO[0000] Create a temp directory at /var/folders/gw/6ckgw32n7rz4yncmkkpsvjl80000gn/T/bundle-2170207577  container-tool=podman
DEBU[0000] Pulling and unpacking container image         container-tool=podman
INFO[0000] running /opt/podman/bin/podman pull quay.io/yapei/apicast-operators-bundle:latest  container-tool=podman
ERRO[0002] Trying to pull quay.io/yapei/apicast-operators-bundle:latest...
Error: choosing an image from manifest list docker://quay.io/yapei/apicast-operators-bundle:latest: no image found in image index for architecture "amd64", variant "", OS "linux"  container-tool=podman
Error: error pulling image: Trying to pull quay.io/yapei/apicast-operators-bundle:latest...
Error: choosing an image from manifest list docker://quay.io/yapei/apicast-operators-bundle:latest: no image found in image index for architecture "amd64", variant "", OS "linux"
...

Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jianzhangbjz
Once this PR has been reviewed and has the lgtm label, please assign oceanc80 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

@jianzhangbjz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 0ac959b link true /test verify
ci/prow/unit-registry 0ac959b link true /test unit-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@grokspawn
Copy link
Contributor

grokspawn commented Dec 12, 2024

Hi @jianzhangbjz
You're right that we don't want to modify ./staging contents, since they get sync'd from the CNCF project and could easily get stomped on.
I'm of two minds on the subject of this alpha level feature needing support.
I think it's OK to add a new, optional flag to provide the capability, still defaulting to the existing behavior, like here. And that would be available in downstream opm versions at the latest unreleased OCP version.
But I think that we would not backport this feature functionality without a really compelling argument.
cc: @joelanford

@joelanford
Copy link
Member

Bundles images explicitly should NOT be multi-arch images. They contain just plaintext files, so they are not platform-specific.

Only images that contain executable binaries need to be multi-arch. And the manifests inside of a bundle images should always reference the multi-arch manifest of the controller and related images.

Is the validate bundle command failing on scratch-based bundle images?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants