openshift-checks: have playbooks invoke std_include #5026
Conversation
|
@sosiouxme, I'll try and take a look at this. |
| - include: ../openshift-cluster/evaluate_groups.yml | ||
| - include: ../openshift-cluster/std_include.yml | ||
| tags: | ||
| - always |
There was a problem hiding this comment.
Why add this if the main plays of this playbook have no tags?!
There was a problem hiding this comment.
Cargo-culting. But I did learn that tags are actually being used on playbook runs, just not in the way I expected. They're used to exclude certain things (as opposed to --tags which is a whitelist). So I left well enough alone. But thinking about it, I don't see why that use case would need to have this tagged always either.
I'll update #4570 accordingly. |
| @@ -1,5 +1,7 @@ | |||
| --- | |||
| - include: ../openshift-cluster/evaluate_groups.yml | |||
| - include: ../openshift-cluster/std_include.yml | |||
There was a problem hiding this comment.
Tried this locally, and I'm getting:
Failure summary:
1. Hosts: node1
Play: Gather and set facts for node hosts
Task: Warn user about bad openshift_hostname values
Message: The conditional check 'lookupip.stdout not in ansible_all_ipv4_addresses' failed. The error was: error while evaluating conditional (lookupip.stdout not in ansible_all_ipv4_addresses): Unable to look up a name or access an attribute in template string ({% if lookupip.stdout not in ansible_all_ipv4_addresses %} True {% else %} False {% endif %}).
Make sure your variable name does not contain invalid characters like '-': argument of type 'StrictUndefined' is not iterable
The error appears to have been in '/home/vagrant/src/github.com/openshift/openshift-ansible/playbooks/common/openshift-cluster/validate_hostnames.yml': line 12, column 5, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:
failed_when: false
- name: Warn user about bad openshift_hostname values
^ here
Strangely, only node1 failed; other 3 hosts were okay.
|
I'm still not sure why |
|
aos-ci-test |
|
Not sure what happened with 1392837 - I guess try again :( |
|
aos-ci-test |
|
merge |
|
https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/821/ epel is really not my friend today. also flake openshift/origin#13975 did not see anything else that looked like a result of this PR @rhcarvalho or @sdodson would you mind a manual merge please... |
|
wasn't able to get past yum flake openshift/origin#8571 yesterday. hoping it's resolved today. (Looks like the latest build is at least failing for a different reason...) merge |
|
aos-ci-test |
|
Last error was the "template error while templating string" problem that got fixed a few days back. I rebased to start fresh. |
|
aos-ci-test |
|
[merge][severity: bug] |
|
863 failed on openshift/origin#12072 among others [merge][severity: bug] |
|
[test]ing while waiting on the merge queue |
|
Evaluated for openshift ansible test up to 0094265 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/461/) (Base Commit: b2b9e5e) (PR Branch Commit: 0094265) |
|
https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/867/ failed on yum failure openshift/origin#10162 - not sure anything else about the tests was valid. [merge][severity: bug] |
|
Evaluated for openshift ansible merge up to 0094265 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/869/) (Base Commit: 22fc8d8) (PR Branch Commit: 0094265) (Extended Tests: bug) |
@sdodson @kwoodson with fixing the refactor integration tests last night I was sloppy and didn't test what happens with the actual check playbooks. CI doesn't test either. They broke, of course. Here's a quick commit to start fixing that. However the
health.ymlchecks still report:... so did something change about setting that fact?
@rhcarvalho the adhoc playbook will of course need similar alteration. And to get the instant informational failure you'll have to move the first conditional invocation before the std_include.