-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTA-1010: release extract: --include works for a minor level update #1954
base: master
Are you sure you want to change the base?
Conversation
@hongkailiu: This pull request references OTA-1010 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
for k := range config.ClusterCapabilities.KnownCapabilities { | ||
config.Capabilities.KnownCapabilities = append(config.Capabilities.KnownCapabilities, k) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With 1.23 you can now do
for k := range config.ClusterCapabilities.KnownCapabilities { | |
config.Capabilities.KnownCapabilities = append(config.Capabilities.KnownCapabilities, k) | |
} | |
config.Capabilities.KnownCapabilities = append(config.Capabilities.KnownCapabilities, slices.Collect(maps.Keys(config.ClusterCapabilities.KnownCapabilities))...) |
and same thing for EnabledCapabilities
d4e6c35
to
34cce22
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hongkailiu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@hongkailiu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/hold
Requiring openshift/library-go#1908
/cc @wking @petr-muller