Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTA-1010: release extract: --include works for a minor level update #1954

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hongkailiu
Copy link
Member

@openshift-ci openshift-ci bot requested review from petr-muller and wking December 12, 2024 20:06
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 12, 2024

@hongkailiu: This pull request references OTA-1010 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

/hold

Requiring openshift/library-go#1908

/cc @wking @petr-muller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2024
Comment on lines 1243 to 1245
for k := range config.ClusterCapabilities.KnownCapabilities {
config.Capabilities.KnownCapabilities = append(config.Capabilities.KnownCapabilities, k)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With 1.23 you can now do

Suggested change
for k := range config.ClusterCapabilities.KnownCapabilities {
config.Capabilities.KnownCapabilities = append(config.Capabilities.KnownCapabilities, k)
}
config.Capabilities.KnownCapabilities = append(config.Capabilities.KnownCapabilities, slices.Collect(maps.Keys(config.ClusterCapabilities.KnownCapabilities))...)

and same thing for EnabledCapabilities

@hongkailiu hongkailiu force-pushed the OTA-1010 branch 11 times, most recently from d4e6c35 to 34cce22 Compare December 14, 2024 16:18
Copy link
Contributor

openshift-ci bot commented Dec 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hongkailiu
Once this PR has been reviewed and has the lgtm label, please assign wking for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Dec 14, 2024

@hongkailiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd 8d7e2da link true /test e2e-agnostic-ovn-cmd
ci/prow/okd-scos-e2e-aws-ovn 8d7e2da link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants