Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AGENT-966: Reduce dependency from kube-system/cluster-config-v1 when generating the image #9066

Merged
merged 10 commits into from
Oct 17, 2024
Merged

AGENT-966: Reduce dependency from kube-system/cluster-config-v1 when generating the image #9066

merged 10 commits into from
Oct 17, 2024

Conversation

andfasano
Copy link
Contributor

@andfasano andfasano commented Oct 2, 2024 •
edited
Loading

The following patch refactored the logic in the ClusterInfo asset for retrieving information from the kube-system/cluster-config-v1, for the following entities:

  • ImageDigestMirrorSets
  • ImageContentPolicies
  • APIDNSName
  • ClusterName
  • SSH key
  • FIPS

Thus removing completely the dependency on the kube-system/cluster-config-v1 resource.

Tip: See individual commits for the specific details related to each field

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 2, 2024 •
edited by openshift-ci bot
Loading

@andfasano: This pull request references AGENT-966 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

/draft

The following patch refactored the logic in the ClusterInfo asset when retrieving information from the kube-system/cluster-config-v1, for the following entities:

  • ImageDigestMirrorSets
  • ImageContentPolicies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 2, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2024
@openshift-ci openshift-ci bot requested review from rna-afk and rwsu October 2, 2024 17:33
@andfasano andfasano force-pushed the day2-reduce-cluster-config-v1-dependency branch from dffb13f to 44375a8 Compare October 3, 2024 09:21
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2024 •
edited by openshift-ci bot
Loading

@andfasano: This pull request references AGENT-966 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

/draft

The following patch refactored the logic in the ClusterInfo asset when retrieving information from the kube-system/cluster-config-v1, for the following entities:

  • ImageDigestMirrorSets
  • ImageContentPolicies
  • APIDNSName

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano andfasano force-pushed the day2-reduce-cluster-config-v1-dependency branch from a25f0a9 to b10bcb4 Compare October 3, 2024 15:10
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2024 •
edited by openshift-ci bot
Loading

@andfasano: This pull request references AGENT-966 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

/draft

The following patch refactored the logic in the ClusterInfo asset when retrieving information from the kube-system/cluster-config-v1, for the following entities:

  • ImageDigestMirrorSets
  • ImageContentPolicies
  • APIDNSName
  • ClusterName
  • SSH key

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano andfasano force-pushed the day2-reduce-cluster-config-v1-dependency branch from 1dab7a7 to 8f107cc Compare October 4, 2024 16:01
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 4, 2024 •
edited by openshift-ci bot
Loading

@andfasano: This pull request references AGENT-966 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

/draft

The following patch refactored the logic in the ClusterInfo asset when retrieving information from the kube-system/cluster-config-v1, for the following entities:

  • ImageDigestMirrorSets
  • ImageContentPolicies
  • APIDNSName
  • ClusterName
  • SSH key
  • FIPS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano andfasano force-pushed the day2-reduce-cluster-config-v1-dependency branch from 8f107cc to d5504ba Compare October 4, 2024 16:44
@andfasano andfasano changed the title [WIP] AGENT-966: Reduce dependency from kube-system/cluster-config-v1 when generating the image AGENT-966: Reduce dependency from kube-system/cluster-config-v1 when generating the image Oct 4, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 4, 2024
@andfasano
Copy link
Contributor Author

/hold

Requires rbac update first in the oc command for passing the add nodes CI job

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 4, 2024 •
edited by openshift-ci bot
Loading

@andfasano: This pull request references AGENT-966 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

/draft

The following patch refactored the logic in the ClusterInfo asset when retrieving information from the kube-system/cluster-config-v1, for the following entities:

  • ImageDigestMirrorSets
  • ImageContentPolicies
  • APIDNSName
  • ClusterName
  • SSH key
  • FIPS

Tip: See individual commits for the specific details related to each field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 4, 2024 •
edited by openshift-ci bot
Loading

@andfasano: This pull request references AGENT-966 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

The following patch refactored the logic in the ClusterInfo asset for retrieving information from the kube-system/cluster-config-v1, for the following entities:

  • ImageDigestMirrorSets
  • ImageContentPolicies
  • APIDNSName
  • ClusterName
  • SSH key
  • FIPS

Thus removing completely the dependency on the kube-system/cluster-config-v1 resource.

Tip: See individual commits for the specific details related to each field

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano
Copy link
Contributor Author

/test verify-vendor

@andfasano andfasano force-pushed the day2-reduce-cluster-config-v1-dependency branch 2 times, most recently from d5504ba to 99d3d8d Compare October 7, 2024 13:44
@andfasano andfasano mentioned this pull request Oct 7, 2024
Merged
@andfasano
Copy link
Contributor Author

Requires openshift/oc#1895

@andfasano
Copy link
Contributor Author

cc @zaneb

@andfasano
Copy link
Contributor Author

/test e2e-agent-compact-ipv4-add-nodes

@andfasano andfasano mentioned this pull request Oct 8, 2024
Merged
@andfasano
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2024
@andfasano
Copy link
Contributor Author

/test e2e-agent-compact-ipv4-add-nodes

@andfasano
Copy link
Contributor Author

/retest

@andfasano
Copy link
Contributor Author

/test e2e-agent-compact-ipv4-add-nodes

rwsu
rwsu reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit.

/approve

pkg/asset/agent/joiner/clusterinfo.go Outdated Show resolved Hide resolved
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rwsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2024
@andfasano
Copy link
Contributor Author

/retest

@andfasano
Copy link
Contributor Author

/test e2e-agent-compact-ipv4-add-nodes

@andfasano
retrieve imageDigestMirrorSets (and imageContentPolicies) from cluste…
087994b 
…r resources
@andfasano
add new it custom command IsoCmpRegEx to allow regex comparison
81ac30f
@andfasano
retrieve APIDNSName from cluster infrastructure resource
498db3b
@andfasano
retrieve cluster name from API DNS name
d1d8ceb
@andfasano
vendoring github.com/openshift/api/machineconfiguration
a84e163 
required to load (and test) the worker machineconfig resource used for extracting ssh key
@andfasano
retrieve SSH key from 99-worker-ssh machineconfig resource
b74d38b
@andfasano
retrieve FIPS from 99-worker-fips machineconfig resource
b13476b
@andfasano
remove unused code related to kube-system/cluster-config-v1 resource
ae10c5f
@andfasano
minor code refactoring, tests improvement
082c6cc
@andfasano
vendoring missing files for github.com/openshift/client-go/machinecon…
e503ce1 
…figuration
@andfasano andfasano force-pushed the day2-reduce-cluster-config-v1-dependency branch from 99d3d8d to e503ce1 Compare October 15, 2024 16:41
@pawanpinjarkar
Copy link
Contributor

/retest

@pawanpinjarkar
Copy link
Contributor

/retest-required

1 similar comment
@pawanpinjarkar
Copy link
Contributor

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/terraform-verify-vendor 113f5b1eef33d744a94c31a6a1ac50af806c5a5b link true /test terraform-verify-vendor
ci/prow/terraform-images 113f5b1eef33d744a94c31a6a1ac50af806c5a5b link true /test terraform-images
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage e503ce1 link false /test e2e-agent-compact-ipv4-appliance-diskimage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pawanpinjarkar
Copy link
Contributor

/retest-required

@pawanpinjarkar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 79576e9 into openshift:master Oct 17, 2024
26 of 27 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.18.0-202410170841.p0.g79576e9.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.18.0-202410170841.p0.g79576e9.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.18.0-202410170841.p0.g79576e9.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.18.0-202410170841.p0.g79576e9.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwsu rwsu rwsu left review comments

@rna-afk rna-afk Awaiting requested review from rna-afk

Assignees

@pawanpinjarkar pawanpinjarkar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andfasano @openshift-ci-robot @pawanpinjarkar @openshift-bot @rwsu