OCPBUGS-46438: Pipeline visualisation shows all tasks as Failed and after that goes to Running state

[lokanandaprabhu]

Fixes:
https://issues.redhat.com/browse/OCPBUGS-46438

Analysis / Root cause:
By default user was shown Failed state if there is no TaskRun details available.

Solution Description:
Since we already have a alert to show if there is no task available for the resource, we can remove the the default failed state added and if the PipelineRun is failed also, we don't have pipelineRun.spec.status attribute in the resource.

Screen shots / Gifs for design review:

----BEFORE---

Screen.Recording.2024-12-16.at.2.37.17.PM.mov

----Shared by Pipelines team---

pipeline.mp4

---

---AFTER----

Screen.Recording.2024-12-16.at.2.39.10.PM.mov

---If no task---

Screen.Recording.2024-12-16.at.4.03.01.PM.mov

---

Unit test coverage report:
NA

Test setup:

1. Create below PLR and ReRun (I am only able to reproduce this issue while using resolver)

kind: PipelineRun
apiVersion: tekton.dev/v1
metadata:
  name: run-basic-pipeline-from-git
spec:
  pipelineRef:
    resolver: git
    params:
    - name: url
      value: https://github.com/lokanandaprabhu/pipelines-testing
    - name: revision
      value: main
    - name: pathInRepo
      value: pipeline.yaml
  params:
  - name: username
    value: admin

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-46438, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-46438

Analysis / Root cause:
By default user was shown Failed state if there is no TaskRun details available.

Solution Description:
Since we already have a alert to show if there is no task available for the resource, we can remove the the default failed state added and if the PipelineRun is failed also, we don't have pipelineRun.spec.status attribute in the resource.

Screen shots / Gifs for design review:

----BEFORE---

Screen.Recording.2024-12-16.at.2.37.17.PM.mov

---

---AFTER----

Screen.Recording.2024-12-16.at.2.39.10.PM.mov

---If no task---

Screen.Recording.2024-12-16.at.4.03.01.PM.mov

---

Unit test coverage report:
NA

Test setup:

1. Create below PLR and ReRun (I am only able to reproduce this issue while using resolver)

kind: PipelineRun
apiVersion: tekton.dev/v1
metadata:
 name: run-basic-pipeline-from-git
spec:
 pipelineRef:
   resolver: git
   params:
   - name: url
     value: https://github.com/lokanandaprabhu/pipelines-testing
   - name: revision
     value: main
   - name: pathInRepo
     value: pipeline.yaml
 params:
 - name: username
   value: admin

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/pipelines-plugin/OWNERS [lokanandaprabhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lokanandaprabhu]

/jira refresh

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-46438, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-46438, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-46438

Analysis / Root cause:
By default user was shown Failed state if there is no TaskRun details available.

Solution Description:
Since we already have a alert to show if there is no task available for the resource, we can remove the the default failed state added and if the PipelineRun is failed also, we don't have pipelineRun.spec.status attribute in the resource.

Screen shots / Gifs for design review:

----BEFORE---

Screen.Recording.2024-12-16.at.2.37.17.PM.mov

----Shared by Pipelines team---

pipeline.mp4

---

---AFTER----

Screen.Recording.2024-12-16.at.2.39.10.PM.mov

---If no task---

Screen.Recording.2024-12-16.at.4.03.01.PM.mov

---

Unit test coverage report:
NA

Test setup:

1. Create below PLR and ReRun (I am only able to reproduce this issue while using resolver)

kind: PipelineRun
apiVersion: tekton.dev/v1
metadata:
 name: run-basic-pipeline-from-git
spec:
 pipelineRef:
   resolver: git
   params:
   - name: url
     value: https://github.com/lokanandaprabhu/pipelines-testing
   - name: revision
     value: main
   - name: pathInRepo
     value: pipeline.yaml
 params:
 - name: username
   value: admin

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@lokanandaprabhu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	92c01a3	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-console	92c01a3	link	true	/test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[vikram-raj]

Can we keep the status as Idle here if none of the conditions match?