Skip to content

Commit

Permalink
pkg/cvo/cvo_scenarios_test.go: Modify TestCVO_ParallelError
Browse files Browse the repository at this point in the history
Due to the introduced filtering of UpdateError errors before setting the
Failing condition, it is needed to update the TestCVO_ParallelError
test, as its errors are getting rightfully filtered due to their
UpdateEffect being None. This commit is utilizing this chance to
update the UpdateEffect of one of the errors to test the filtering here
as well.
  • Loading branch information
DavidHurta authored and openshift-cherrypick-robot committed Sep 4, 2024
1 parent 875c0d8 commit 245e690
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/cvo/cvo_scenarios_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3568,7 +3568,7 @@ func TestCVO_ParallelError(t *testing.T) {
},
"0000_20_a_file.yaml": nil,
"0000_20_b_file.yaml": &payload.UpdateError{
UpdateEffect: payload.UpdateEffectNone,
UpdateEffect: payload.UpdateEffectFail,
Message: "Failed to reconcile 20-b-file resource",
},
}}
Expand Down Expand Up @@ -3753,7 +3753,7 @@ func TestCVO_ParallelError(t *testing.T) {
{Type: DesiredReleaseAccepted, Status: configv1.ConditionTrue, Reason: "PayloadLoaded",
Message: "Payload loaded version=\"1.0.0-abc\" image=\"image/image:1\" architecture=\"" + architecture + "\""},
{Type: configv1.OperatorAvailable, Status: configv1.ConditionFalse},
{Type: ClusterStatusFailing, Status: configv1.ConditionTrue, Reason: "MultipleErrors", Message: "Multiple errors are preventing progress:\n* Failed to reconcile 10-a-file resource\n* Failed to reconcile 20-b-file resource"},
{Type: ClusterStatusFailing, Status: configv1.ConditionTrue, Message: "Failed to reconcile 20-b-file resource"},
{Type: configv1.OperatorProgressing, Status: configv1.ConditionTrue, Reason: "MultipleErrors", Message: "Unable to apply 1.0.0-abc: an unknown error has occurred: MultipleErrors"},
{Type: configv1.RetrievedUpdates, Status: configv1.ConditionFalse},
},
Expand Down

0 comments on commit 245e690

Please sign in to comment.