Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SERVER_SECRET param to an optional workspace #12

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

vdemeester
Copy link
Member

Signed-off-by: Vincent Demeester [email protected]

@openshift-ci openshift-ci bot requested a review from otaviof December 19, 2023 16:54
Copy link

openshift-ci bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester
Copy link
Member Author

cc @Aneesh-M-Bhat
We shouldn't require the user to have this secret, hence changing the Task to use optional workspace instead.

Copy link

openshift-ci bot commented Dec 19, 2023

@vdemeester: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/osp-nightly-ocp-414-e2e d7437e3 link true /test osp-nightly-ocp-414-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vdemeester vdemeester force-pushed the move-secret-to-optional-workspace branch from d7437e3 to 1ea10bc Compare December 20, 2023 08:42
@vdemeester vdemeester merged commit 9781ecd into main Dec 20, 2023
9 of 15 checks passed
@vdemeester vdemeester deleted the move-secret-to-optional-workspace branch December 20, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant