Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ Add NotesViewer component #2173

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Feature/ Add NotesViewer component #2173

merged 6 commits into from
Nov 18, 2024

Conversation

xkopenreview
Copy link
Collaborator

this is a component for users to view v2 notes array formatted like notes
access should be controlled by group readership

when there are many notes, it's better to check pagination to improve page performance

sample config:

// Webfield component
return {
  component: 'NotesViewer',
  version: 1,
  properties: {
    header: {
      title: `Notes Viewer`,
      instructions: `Paste notes json and view it formatted`
    }
  }
}

@xkopenreview
Copy link
Collaborator Author

replacement of #2149

Copy link
Member

@carlosmondra carlosmondra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Works as expected.

@xkopenreview
Copy link
Collaborator Author

changes to export CSV should not interfere with other csv download
so please also test console download if possible

@carlosmondra
Copy link
Member

changes to export CSV should not interfere with other csv download so please also test console download if possible

Tested both things. Works as expected.

Copy link
Member

@enrubio enrubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. Exports in all consoles seem to be working the same.

@enrubio enrubio merged commit f7f2ecc into master Nov 18, 2024
2 checks passed
@enrubio enrubio deleted the feature/notes-viewer branch November 18, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants