Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ Notification search #2164

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

xkopenreview
Copy link
Collaborator

when the user is involved in many conferences, it's hard to check the notifications from a certain conference.

this pr should add the search input in notifications page so that user can search the email subject

@xkopenreview
Copy link
Collaborator Author

currently there's no unit tests or integration tests for notification page which is not good

@carlosmondra
Copy link
Member

carlosmondra commented Nov 4, 2024

So this PR makes a search on all messages using subject prefix? I feel like most people will expect to be a search over any part of the text. Is this related to an issue we are trying to fix?

@xkopenreview
Copy link
Collaborator Author

So this PR makes a search on all messages using subject prefix? I feel like most people will expect to be a search over any part of the text. Is this related to an issue we are trying to fix?

related to openreview/openreview#201 to filter messages from certain venue

@carlosmondra
Copy link
Member

So this PR makes a search on all messages using subject prefix? I feel like most people will expect to be a search over any part of the text. Is this related to an issue we are trying to fix?

related to openreview/openreview#201 to filter messages from certain venue

Wouldn't it be easier to use the domain keyword?

@xkopenreview
Copy link
Collaborator Author

So this PR makes a search on all messages using subject prefix? I feel like most people will expect to be a search over any part of the text. Is this related to an issue we are trying to fix?

related to openreview/openreview#201 to filter messages from certain venue

Wouldn't it be easier to use the domain keyword?

i think there's no domain keyword
if it can be added and support regex it will be better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants