-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ Prompt Message: only the last message is displayed #2135
base: master
Are you sure you want to change the base?
Conversation
proceed with cleanup and test update if the implementation is ok |
Is it necessary to change the style of the banner? |
if we still show at most 1 message then no |
I like the changes in the PR, but I like the current style better. It matches OpenReview styling. In what case would it be better to show two messages (or more)? Maybe we can do without that. |
please take a look at changes in 8cf01da |
The styling helps. I like it better now. However, the message is a bit easy to miss. The current one is very clear. My guess is that having it appear below the header will make it easier to notice. Also if the width of the message could be larger, I think it would help. I tried the mobile view and it's not possible to close the banner from there. Also as a separate issue: The profile page does not show up properly from the mobile view. Not sure if there is an issue already. I can create it if not. |
|
this is expected. it's checking for mobile view and removed the close button |
I think I liked the close button from before better. Is it possible to make the message background wider? |
do you mean wider or taller? |
Wider 😬 |
Changes look so much better. I'm not sure about the Also how do you configure how long a message stays on the screen? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes!
this pr change the way which notification is shown
so that:
new promptError/promptMessage/promptLogin should just replace the one used to be defined in global.js
current promptLogin accept a user argument which is used to determine whether to show Login or Login as a different user when editor can't get reader or signature
this apply only to v1 forum and note editor, the new readers and signature component has their own error handing so the logic is removed.