Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ Prompt Message: only the last message is displayed #2135

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

xkopenreview
Copy link
Collaborator

@xkopenreview xkopenreview commented Oct 16, 2024

this pr change the way which notification is shown
so that:

  1. multiple messages can be shown (currently set to 2 max)
  2. different message types can show for different duration and allow custom duration to be passed
  3. messages can be closed
  4. messages can show markdown/mathjax

new promptError/promptMessage/promptLogin should just replace the one used to be defined in global.js


current promptLogin accept a user argument which is used to determine whether to show Login or Login as a different user when editor can't get reader or signature
this apply only to v1 forum and note editor, the new readers and signature component has their own error handing so the logic is removed.

@xkopenreview
Copy link
Collaborator Author

proceed with cleanup and test update if the implementation is ok

@xkopenreview xkopenreview linked an issue Oct 24, 2024 that may be closed by this pull request
@carlosmondra
Copy link
Member

carlosmondra commented Nov 13, 2024

Is it necessary to change the style of the banner?

@xkopenreview
Copy link
Collaborator Author

Is it necessary to change the style of the banner?

if we still show at most 1 message then no
if showing multiple using current banner style it's weird

@carlosmondra
Copy link
Member

carlosmondra commented Nov 18, 2024

Is it necessary to change the style of the banner?

if we still show at most 1 message then no if showing multiple using current banner style it's weird

I like the changes in the PR, but I like the current style better. It matches OpenReview styling. In what case would it be better to show two messages (or more)? Maybe we can do without that.

@xkopenreview
Copy link
Collaborator Author

Is it necessary to change the style of the banner?

please take a look at changes in 8cf01da

@carlosmondra
Copy link
Member

The styling helps. I like it better now. However, the message is a bit easy to miss. The current one is very clear. My guess is that having it appear below the header will make it easier to notice. Also if the width of the message could be larger, I think it would help.

I tried the mobile view and it's not possible to close the banner from there.

Also as a separate issue: The profile page does not show up properly from the mobile view. Not sure if there is an issue already. I can create it if not.

@xkopenreview
Copy link
Collaborator Author

Also as a separate issue: The profile page does not show up properly from the mobile view. Not sure if there is an issue already. I can create it if not.

#2185

@xkopenreview
Copy link
Collaborator Author

I tried the mobile view and it's not possible to close the banner from there.

this is expected. it's checking for mobile view and removed the close button
i set the mobile view display time shorter than desktop view
2 seconds in mobile, 4 seconds for desktop

@carlosmondra
Copy link
Member

I think I liked the close button from before better.

Is it possible to make the message background wider?

@xkopenreview
Copy link
Collaborator Author

Is it possible to make the message background wider?

do you mean wider or taller?

@carlosmondra
Copy link
Member

Is it possible to make the message background wider?

do you mean wider or taller?

Wider 😬

@xkopenreview xkopenreview marked this pull request as ready for review November 21, 2024 20:19
@carlosmondra
Copy link
Member

Changes look so much better.

I'm not sure about the close button. I think the X that we had in the previous banner looked better. It blended better with the style of the banner.

Also how do you configure how long a message stays on the screen?

Copy link
Member

@carlosmondra carlosmondra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks

Copy link
Contributor

@emily-grabowski emily-grabowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompt Message: only the last message is displayed
5 participants