Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ Reply preview for v2 note invitation #2120

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

xkopenreview
Copy link
Collaborator

this pr should add a note (or reply) preview for v2 note invitation

@celestemartinez
Copy link
Member

I am not sure how helpful this is for a couple of reasons:

  1. This only works for the paper-specific invitations. This means a PC would have to go to a paper-specific invitation to preview any changes, but then they would have to make the changes to the super invitation (which has no preview)
  2. PCs don't know that changing the fieldname will not rename the field, but create a new field with that name (and that the previous field needs to be deleted with {"delete": True}). But I am not sure how we can make this clear in the UI

@xkopenreview
Copy link
Collaborator Author

  1. This only works for the paper-specific invitations. This means a PC would have to go to a paper-specific invitation to preview any changes, but then they would have to make the changes to the super invitation (which has no preview)
  2. PCs don't know that changing the fieldname will not rename the field, but create a new field with that name (and that the previous field needs to be deleted with {"delete": True}). But I am not sure how we can make this clear in the UI

can you give an example of super invitation where preview is not shown?
this function can be added to the json editor which is used in workflow invitation content field
right now for invitation editor i think we still expect user to modify json directly

@celestemartinez
Copy link
Member

  1. This only works for the paper-specific invitations. This means a PC would have to go to a paper-specific invitation to preview any changes, but then they would have to make the changes to the super invitation (which has no preview)
  2. PCs don't know that changing the fieldname will not rename the field, but create a new field with that name (and that the previous field needs to be deleted with {"delete": True}). But I am not sure how we can make this clear in the UI

can you give an example of super invitation where preview is not shown? this function can be added to the json editor which is used in workflow invitation content field right now for invitation editor i think we still expect user to modify json directly

I was trying to use the preview for the invitation ICLR.cc/2024/Conference/-/Official_Review, but I could only see the preview for a paper invitation, for example ICLR.cc/2024/Conference/Submission1/-/Official_Review.

@xkopenreview
Copy link
Collaborator Author

I was trying to use the preview for the invitation ICLR.cc/2024/Conference/-/Official_Review, but I could only see the preview for a paper invitation, for example ICLR.cc/2024/Conference/Submission1/-/Official_Review.

thanks.
a6d2366 should show preview for invitation of note invitation

@enrubio
Copy link
Member

enrubio commented Nov 13, 2024

this function can be added to the json editor which is used in workflow invitation content field

This is referring to the venue configuration changes right?

I think this is cool to have. I'm worried though about PCs seeing this, making changes directly in the invitation, then running a stage which would overwrite those changes and being confused.

@xkopenreview
Copy link
Collaborator Author

this function can be added to the json editor which is used in workflow invitation content field

This is referring to the venue configuration changes right?

I think this is cool to have. I'm worried though about PCs seeing this, making changes directly in the invitation, then running a stage which would overwrite those changes and being confused.

the json editor already have preview i think
it has 3 tabs:

  • edit by field property
  • edit with json
  • preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants