-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/ Edge browser - only show entities associated with parent on initial load #2110
base: master
Are you sure you want to change the base?
Conversation
Does it mean that if, in the case of TMLR, an AE searches for a reviewer who does not have an Edge with the submission in the first colum, the reviewer will still show up in the second column? |
that's right. |
So the search is performed on all the edges just using the invitation as the filter, correct? |
i think we can either has some setting in the traverse invitation to denote this or has a new query param to control whether to filter out those entities with no relation with parent |
I would prefer to have a parameter in the edge browser. @celestemartinez do you have any thoughts? |
currently edge browser show items when it has traverse edge, even if it's not related to the parent entity by traverse edge (assignment) or browse edge (affinity score) at all.
this pr should filter out such items on initial load
when user perform search or max quota filtering, such items should still be displayed (refer to #1480 for rationale)