Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "configure.ac: generate prte_version.h properly" #2094

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Revert "configure.ac: generate prte_version.h properly" #2094

merged 1 commit into from
Dec 7, 2024

Conversation

rhc54
Copy link
Contributor

@rhc54 rhc54 commented Dec 7, 2024

This reverts commit b7196af.

@rhc54
Copy link
Contributor Author

rhc54 commented Dec 7, 2024

@jsquyres @hppritcha Sigh - this simple AC_CONFIG_HEADERS change still isn't correct. If you start with a clean Git checkout on Rocky 9, it will generate a file src/include/prte_config.h?.in - note the addition of the ? character, which totally busts configure. I'm not sure where the bad character is coming from, but clearly we cannot move forward with this change.

@rhc54 rhc54 merged commit 99681b6 into openpmix:master Dec 7, 2024
13 checks passed
@rhc54 rhc54 deleted the topic/rvrt branch December 7, 2024 14:40
@rhc54
Copy link
Contributor Author

rhc54 commented Dec 7, 2024

FWIW: I was able to determine that the "bad" character is a newline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rhc54