Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintain correct ref count of child jobs #2093

Merged
merged 1 commit into from
Dec 8, 2024
Merged

maintain correct ref count of child jobs #2093

merged 1 commit into from
Dec 8, 2024

Conversation

HawkmoonEternal
Copy link

Attempt to fix issue #2084.

  1. Changed cleanup_job() to remove the job from the parent's child list and decrement the ref count.
  2. Likewise, prte_job_destruct() now destructs the child list without first removing the job data objects, so their ref counts get decremented.

@HawkmoonEternal HawkmoonEternal mentioned this pull request Dec 5, 2024
Closed
@openpmix openpmix deleted a comment from github-actions bot Dec 5, 2024
@rhc54
Copy link
Contributor

rhc54 commented Dec 8, 2024

I have verified that this passes the provided reproducer.

@rhc54 rhc54 merged commit bc1c107 into openpmix:master Dec 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HawkmoonEternal @rhc54