Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prte.c: a prefix of "/" is ok
It's not an error if the prefix ends up being a plain "/". More
specifically, if we strip off all trailing "/" characters from the
prefix and end up with an empty string, then the prefix is just "/".
Protect against a NULL prefix being added to the app's attributes.
Protect against a double-/ in the prted cmd path in the ssh
launch component.
Signed-off-by: Jeff Squyres [email protected]
Signed-off-by: Ralph Castain [email protected]
(cherry picked from commit ce7f686)
Correctly translate the plm_rsh MCA params
Need to convert to plm_ssh
Signed-off-by: Ralph Castain [email protected]
(cherry picked from commit d7d0095)
Fix add-hostfile and add-host operations
When in a managed allocation, allow addition of nodes
provided that either (a) all the nodes in the managed
portion of the allocation have the same #slots in them
so we can infer how many are in the new nodes, or (b)
the user specifies the #slots for the new nodes.
Check node names as well as aliases for match.
Add a new ras component to simulate a managed allocation.
Signed-off-by: Ralph Castain [email protected]
(cherry picked from commit bffbc40)
Add print functions for node, job, and proc flags
Make it easier to understand what flags are set.
Signed-off-by: Ralph Castain [email protected]
(cherry picked from commit f4e67ac)
Add missing "acquire_object"
Ensure we have a memory barrier prior to
using the object when called from the
progress thread.
Signed-off-by: Ralph Castain [email protected]
(cherry picked from commit 2835e09)
Fix handling of "--" in cmd line
Allow the app parser to see the line and rely on
the PMIx cmd line parser to handle it.
Signed-off-by: Ralph Castain [email protected]
(cherry picked from commit 81b4e60)
Use global PRRTE event base for sigchld callback
Even when we utilize multiple odls progress threads
to locally fork/exec procs, we have to direct the
waitpid callback to the global event base to ensure
that all servicing of sigchld returns happens in a
thread-safe environment.
Remove the unused event base priorities as an
unnecessary distraction.
Signed-off-by: Ralph Castain [email protected]
(cherry picked from commit 066b560)
Remove the event base param to prte_wait_cb
Reduce potential for mistakes by locking the
wait callbacks to occur in the main event thread.
Signed-off-by: Ralph Castain [email protected]
(cherry picked from commit ad63c0f)
Fix OMPI cmd line processing
Don't touch provided values of MCA params when
converting single-dash to double-dash options.
Signed-off-by: Ralph Castain [email protected]
(cherry picked from commit 0da2000)