Use global PRRTE event base for sigchld callback #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even when we utilize multiple odls progress threads to locally fork/exec procs, we have to direct the waitpid callback to the global event base to ensure that all servicing of sigchld returns happens in a thread-safe environment. Remove the unused event base priorities as an unnecessary distraction. Signed-off-by: Ralph Castain <[email protected]>
|
@rhc54 Thank you very much! I confirm that this fixes the hang 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when we utilize multiple odls progress threads to locally fork/exec procs, we have to direct the
waitpid callback to the global event base to ensure that all servicing of sigchld returns happens in a thread-safe environment.
Remove the unused event base priorities as an
unnecessary distraction.