Skip to content

Commit

Permalink
configure.ac: generate prte_version.h properly
Browse files Browse the repository at this point in the history
Have prte_version.h generated via AC_CONFIG_HEADERS, not
AC_CONFIG_FILES.  This properly quotes strings (which technically
doesn't matter here since prte_version.h doesn't include any strings)
and also won't overwrite the resulting .h file if it hasn't changed.

NOTE: This is a fix for the original commit that brought in this
functionality (4da431a) which broke in at least some Linux
environments.  Apparently, AC_CONFIG_HEADERS -- unlike AC_CONFIG_FILES
-- does not like extra newlines at the beginning or end of the file
list parameter in at least some Linux environments (although it seems
to work find on macOS).  Shrug!

Signed-off-by: Jeff Squyres <[email protected]>
(cherry picked from commit b7196af)
  • Loading branch information
jsquyres authored and rhc54 committed Dec 5, 2024
1 parent 37e0525 commit 7d536b5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,8 @@ AC_MSG_RESULT([$ltversion])

# List header files to generate

AC_CONFIG_HEADERS([src/include/prte_config.h])
AC_CONFIG_HEADERS([src/include/prte_config.h
include/prte_version.h])

prte_show_subtitle "Initialization, setup"

Expand Down Expand Up @@ -1016,7 +1017,6 @@ AC_CONFIG_FILES([
config/Makefile
contrib/Makefile
include/Makefile
include/prte_version.h
docs/Makefile
src/docs/Makefile
src/docs/prrte-rst-content/Makefile
Expand Down

0 comments on commit 7d536b5

Please sign in to comment.