-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defining ML-KEM and ML-DSA secret keys to be in seed format #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me aside from one further issue. We use ML-KEM.Decaps
and ML-DSA.Sign
directly with the secret key (seed) which is only defined for the expanded key. For ML-KEM we would first need to call ML-KEM.KeyGen_internal
to obtain the actual key that can be input to Decaps.
This is why it says in the added text to the secret key format:
I think it is easier to state that where the key format is defined, because it is up to the implementation when to expand the secret key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-read and now agree with you. It should be sufficiently clear, especially since we clarify that mlkemSecretKey
is the decapsulation key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, just one minor detail: Could you add a changelog entry, Falko?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for me, with changelog looks good!
- openpgp-pqc/draft-openpgp-pqc#146 - Replace draft-ietf-openpgp-pqc-04 with draft-ietf-openpgp-pqc-05
- openpgp-pqc/draft-openpgp-pqc#146 - Replace draft-ietf-openpgp-pqc-04 with draft-ietf-openpgp-pqc-05
Closes #139
Closes #108