-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix configHash in app configuration #546
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #546 +/- ##
=========================================
Coverage ? 83.71%
Complexity ? 479
=========================================
Files ? 42
Lines ? 2345
Branches ? 233
=========================================
Hits ? 1963
Misses ? 299
Partials ? 83 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Hi @taikonavt , I'll need you to sign the OpenID CLA to merge this. See: https://github.com/openid/AppAuth-Android/blob/master/CONTRIBUTING.md Once you've signed it and sent it to the foundation, send me a copy also and I'll get this merged. |
Preview attachment Maxim Goncharov_All WGs_Contribution
Agreement_2020-05-29.pdf
Maxim Goncharov_All WGs_Contribution Agreement_2020-05-29.pdf
234 KB
<https://mail.google.com/mail/u/0?ui=2&ik=38ea670ff3&attid=0.1&permmsgid=msg-f:1668047485033418102&th=1726185995e68d76&view=att&disp=inline>
…On Thu, Jun 18, 2020 at 7:07 PM Iain McGinniss ***@***.***> wrote:
Hi @taikonavt <https://github.com/taikonavt> , I'll need you to sign the
OpenID CLA to merge this.
See: https://github.com/openid/AppAuth-Android/blob/master/CONTRIBUTING.md
Once you've signed it and sent it to the foundation, send me a copy also
and I'll get this merged.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#546 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACH3KQE4TNX7H3BR5TY33FTRXI3TZANCNFSM4NN5TAUA>
.
|
|
In app in Configuration.java configHash didn't work, because configData.readString() remove all bytes from configData, so hash was calculated from empty string every time.