Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix configHash in app configuration #546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

taikonavt
Copy link

In app in Configuration.java configHash didn't work, because configData.readString() remove all bytes from configData, so hash was calculated from empty string every time.

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2020

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@f125925). Learn more about missing BASE report.
Report is 87 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #546   +/-   ##
=========================================
  Coverage          ?   83.71%           
  Complexity        ?      479           
=========================================
  Files             ?       42           
  Lines             ?     2345           
  Branches          ?      233           
=========================================
  Hits              ?     1963           
  Misses            ?      299           
  Partials          ?       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@iainmcgin
Copy link
Member

Hi @taikonavt , I'll need you to sign the OpenID CLA to merge this.

See: https://github.com/openid/AppAuth-Android/blob/master/CONTRIBUTING.md

Once you've signed it and sent it to the foundation, send me a copy also and I'll get this merged.

@taikonavt
Copy link
Author

taikonavt commented Jun 23, 2020 via email

@smartabnman
Copy link

In app in Configuration.java configHash didn't work, because configData.readString() remove all bytes from configData, so hash was calculated from empty string every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants