Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MainUI] Add thing action menu to add new thing page #2921

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

seime
Copy link
Contributor

@seime seime commented Dec 14, 2024

When adding from inbox, there are a few thing options to choose from, ie setting a custom id (and also showing thing file details after #2920 .

Add some of the same actions to route via binding

Copy link

relativeci bot commented Dec 14, 2024

#2565 Bundle Size — 10.9MiB (+0.02%).

e22e16e(current) vs c2ae0ab main#2562(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2565
     Baseline
#2562
No change  Initial JS 1.92MiB 1.92MiB
No change  Initial CSS 577.83KiB 577.83KiB
Change  Cache Invalidation 18.3% 17.65%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2947 2947
No change  Duplicate Modules 152 152
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2565
     Baseline
#2562
Regression  JS 9.11MiB (+0.03%) 9.11MiB
No change  CSS 866.74KiB 866.74KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch seime:thing_optionsProject dashboard


Generated by RelativeCIDocumentationReport issue

}
},
{
text: 'Show equivalent Thing file configuration (basic properties)',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove this from this PR? See #2920 (review).

I would also suggest to refactor the openEntryActions and approveEntry actions to a mixin, which then both inbox-list.vue and choose-thing-type.vue can import. This reduces code duplication and avoids further issues where those two provide different options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants