This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Feat/create document with weasyprint options #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbpenrath
force-pushed
the
feat/create-document-with-weasyprint-options
branch
from
d0ac5de to
a9bc452
Compare
Weasyprint 59.0 add new options to the `Document.write_pdf` method. As we want to use it, we have to pin it to a version greater than equal 59.0
jbpenrath
force-pushed
the
feat/create-document-with-weasyprint-options
branch
from
a9bc452 to
f96f8f9
Compare
jbpenrath
force-pushed
the
feat/create-document-with-weasyprint-options
branch
2 times, most recently
from
719fddb to
6f462a3
Compare
We want Marion consumers be able to use new pdf options offered by weasyprint 59 .0. In order to do that, we add a new `pdf_options` argument to the `AbstractDocument.create` method. Furthermore, weasyprint 59.0 with pdf compression enable is no more compatible with pdfminer extract text. So until this issue is fixed, we disable by default the pdf compression. But consumers are able to enable this option at their own risks through the `pdf_options` argument.
jbpenrath
force-pushed
the
feat/create-document-with-weasyprint-options
branch
from
6f462a3 to
f71b888
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Weasyprint 59.0 introduces new options to pass to the
write_pdfmethod. It could be interesting to allow marion consumers to be able to use them.Since Weasyprint 59.0, the pdfminer extract_text method raises a
TypeErrorwhen PDF compression is enable, so until the issue is fixed, we decide to disable it but allow consumers to enable it at their own risk.Kozea/WeasyPrint#1885
pdfminer/pdfminer.six#886
Proposal
pdf_optionsparameter toAbstractDocument.createmethod