Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add subnutriment in nutrition table if missing and subsub is provided #11136

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

benbenben2
Copy link
Collaborator

What

  • Added some nutrients (isomalt, allulos/psicose, maltitol, sorbitol)
  • Added sub-nutrients when sub-sub-nutrient is provided only. Example: when erythritol is provided only, the direct parent (polyol) is now shown as well between erythitol and carbohydrates

Screenshot

PRODUCT BEFORE
nutrition_product_before

PRODUCT AFTER
nutrition_product_after

EDIT BEFORE
nutrition_edit_after

EDIT AFTER
nutrition_edit_before

Related issue(s) and discussion

@benbenben2 benbenben2 self-assigned this Dec 16, 2024
@benbenben2 benbenben2 requested a review from a team as a code owner December 16, 2024 22:07
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies Food.pm Display multilingual products labels Dec 16, 2024
@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Dec 18, 2024
@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Dec 18, 2024
@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Dec 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2024

❌ 38 Tests Failed:

Tests completed Failed Passed Skipped
7504 38 7466 0
View the top 3 failed tests by shortest run time
tests_integration_api_v2_product_read_t 0036 - get-fields-all-knowledge-panels
Stack Traces | 0.00152s run time
not ok 0036 - get-fields-all-knowledge-panels
tests_integration_api_v2_product_read_t 0038 - get-fields-attribute-groups-all-knowledge-panels
Stack Traces | 0.00156s run time
not ok 0038 - get-fields-attribute-groups-all-knowledge-panels
tests_integration_api_v2_product_read_t 0040 - get-fields-knowledge-panels-knowledge-panels_included-health_card-environment_card
Stack Traces | 0.00157s run time
not ok 0040 - get-fields-knowledge-panels-knowledge-panels_included-health_card-environment_card

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@teolemon
Copy link
Member

/update_tests_results

1 similar comment
@teolemon
Copy link
Member

/update_tests_results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Display Food.pm multilingual products ⭐ top pull request Top pull request. 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
3 participants