Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resources for migration containers #73

Merged
merged 3 commits into from
Nov 4, 2023

Conversation

marlenekoh
Copy link
Contributor

Allow resources limits and requests to be configured for the migration job.

Description

Added the following to values.yaml

datastore:
   engine: memory
   uri:
   uriSecret:
   maxCacheSize:
   maxOpenConns:
   maxIdleConns:
   connMaxIdleTime:
   connMaxLifetime:
   applyMigrations: true
+  migrations:
+    resources: {}

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@marlenekoh marlenekoh changed the title Add resources configuration for wait-for-migration initcontainer, migration job feat: add resources for migration containers Oct 25, 2023
charts/openfga/templates/deployment.yaml Outdated Show resolved Hide resolved
@rhamzeh rhamzeh mentioned this pull request Nov 3, 2023
4 tasks
@rhamzeh rhamzeh enabled auto-merge (squash) November 3, 2023 05:53
@rhamzeh rhamzeh merged commit 7b394d7 into openfga:main Nov 4, 2023
1 check passed
@marlenekoh marlenekoh deleted the add-migration-resources branch November 8, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants