Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stringify OPENFGA_GRPC_TLS_ENABLED #172

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: stringify OPENFGA_GRPC_TLS_ENABLED #172

wants to merge 2 commits into from

Conversation

marlenekoh
Copy link
Contributor

@marlenekoh marlenekoh commented Dec 10, 2024 •
edited
Loading

Pass the value of .Values.grpc.tls.enabled into OPENFGA_GRPC_TLS_ENABLED as a string (i.e. "true", "false") instead of the boolean value

Description

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@marlenekoh marlenekoh requested review from a team as code owners December 10, 2024 07:45
@marlenekoh marlenekoh mentioned this pull request Dec 10, 2024
Open
4 tasks
@marlenekoh marlenekoh changed the title Stringify OPENFGA_GRPC_TLS_ENABLED fix: stringify OPENFGA_GRPC_TLS_ENABLED Dec 10, 2024
rhamzeh
rhamzeh approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marlenekoh !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marlenekoh @rhamzeh