feat: add Common Labels Support #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalyng
approved these changes
Nov 22, 2024
bagnaram
force-pushed
the
bagnaram/helm-common-labels
branch
from
a8cd10d to
b57f95e
Compare
bagnaram
force-pushed
the
bagnaram/helm-common-labels
branch
from
b57f95e to
b9f7e47
Compare
|
Thank you for your contribution to the Helm charts! If you're comfortable with it, we encourage contributors to update documentation where it makes sense. In this case, you may want to mention |
bagnaram
force-pushed
the
bagnaram/helm-common-labels
branch
from
b9f7e47 to
8946980
Compare
bagnaram
force-pushed
the
bagnaram/helm-common-labels
branch
4 times, most recently
from
5555196 to
a5ab670
Compare
|
Thank you for reviewing @hello-caleb ! I am not sure which separate documentation I need to update but I have now provided usage examples. |
bagnaram
force-pushed
the
bagnaram/helm-common-labels
branch
from
a5ab670 to
d2570dc
Compare
rhamzeh
requested changes
Nov 22, 2024
bagnaram
force-pushed
the
bagnaram/helm-common-labels
branch
from
d2570dc to
d34d642
Compare
bagnaram
force-pushed
the
bagnaram/helm-common-labels
branch
from
d34d642 to
3e261f6
Compare
rhamzeh
previously approved these changes
Nov 27, 2024
bagnaram
force-pushed
the
bagnaram/helm-common-labels
branch
from
3e261f6 to
8a82933
Compare
rhamzeh
approved these changes
Nov 27, 2024
|
Thank you @bagnaram :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common Labels to Helm Chart
Description
Adds optional common labels support which gets added to all deployable Kube resources.
References
Review Checklist
mainIf you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)