Refer feedback from #673 and augment documentation #684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refering feedback from the review #673 which adds multiple
namespaces functionality which includes the following:
faas-netes in the operator. Removing the custom implementations
as they are no longer used
Signed-off-by: Martin Dekov [email protected]
Description
Motivation and Context
Feedback from Add multiple namespaces in the operator #673
How Has This Been Tested?
Installed local chart for faas-netes and operator and built custom image with the changes stored and pushed in
martindekov/faas-netes:asd-3
:Tested the operator to check whether the logic for namespaces and secrets is reused properly. Also deployed a function and invoked it in default and custom namespace both in the operator and faas-netes. Also tested whether faas-netes works with the cluster role as expected.
Types of changes
Checklist:
git commit -s