Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data and parsers for new counties #155

Merged
merged 5 commits into from
Aug 18, 2024
Merged

Conversation

declanrjb
Copy link
Contributor

Data now available for Blair, Berks, Beaver, Adams, and Carbon. Parser for Bucks is almost entirely complete but does not yet handle rare exception where races continue over page breaks without headers, incomplete data not included in this commit.

Copy link

Thank you for your contribution! Our duplicate_entries test detected some potential issues in the files you added.

======================================================================
FAIL: test_duplicate_entries (data_tests.test_data.DuplicateEntriesTest.test_duplicate_entries) [2024/20240423__pa__primary__blair__precinct.csv]
----------------------------------------------------------------------
28 duplicate entries detected:

	Headers: ['county', 'precinct', 'office', 'district', 'party', 'candidate', 'votes', 'election_day', 'provisional', 'absentee']:
	Row 86: ['Blair', 'ALTOONA 1', 'ALTERNATE DELEGATE TO THE REPUBLICAN NATIONAL CONVENTION', '', 'REP', 'Write-In: Scattered', '2', '1', '0', '1']
	Row 87: ['Blair', 'ALTOONA 1', 'ALTERNATE DELEGATE TO THE REPUBLICAN NATIONAL CONVENTION', '', 'REP', 'Write-In: Scattered', '1', '0', '0', '1']
	Row 181: ['Blair', 'ALTOONA 1', 'ALTERNATE DELEGATE TO THE REPUBLICAN NATIONAL CONVENTION', '', 'REP', 'Write-In: Scattered', '0', '0', '0', '0']
	Row 1614: ['Blair', 'ALTOONA 4 DIV 1', 'ALTERNATE DELEGATE TO THE REPUBLICAN NATIONAL CONVENTION', '', 'REP', 'Write-In: Scattered', '1', '1', '0', '0']
	Row 1706: ['Blair', 'ALTOONA 4 DIV 1', 'ALTERNATE DELEGATE TO THE REPUBLICAN NATIONAL CONVENTION', '', 'REP', 'Write-In: Scattered', '0', '0', '0', '0']
	Row 3139: ['Blair', 'ALTOONA 6 DIV 1', 'ALTERNATE DELEGATE TO THE REPUBLICAN NATIONAL CONVENTION', '', 'REP', 'Write-In: Scattered', '2', '2', '0', '0']
	Row 3144: ['Blair', 'ALTOONA 6 DIV 1', 'ALTERNATE DELEGATE TO THE REPUBLICAN NATIONAL CONVENTION', '', 'REP', 'Write-In: Scattered', '1', '1', '0', '0']
	Row 3233: ['Blair', 'ALTOONA 6 DIV 1', 'ALTERNATE DELEGATE TO THE REPUBLICAN NATIONAL CONVENTION', '', 'REP', 'Write-In: Scattered', '0', '0', '0', '0']
	Row 4363: ['Blair', 'ALTOONA 7', 'ALTERNATE DELEGATE TO THE REPUBLICAN NATIONAL CONVENTION', '', 'REP', 'Write-In: Scattered', '1', '1', '0', '0']
	Row 4455: ['Blair', 'ALTOONA 7', 'ALTERNATE DELEGATE TO THE REPUBLICAN NATIONAL CONVENTION', '', 'REP', 'Write-In: Scattered', '0', '0', '0', '0']
	[Truncated to 10 examples]

Copy link

Thank you for your contribution! Our vote_breakdown_totals test detected some potential issues in the files you added.

======================================================================
FAIL: test_vote_method_totals (data_tests.test_data.VoteBreakdownTotalsTest.test_vote_method_totals) [2024/20240423__pa__primary__carbon__precinct.csv]
----------------------------------------------------------------------
There are 969 rows where the sum of ['election_day', 'provisional', 'absentee'] is greater than 'votes':

	Headers: ['county', 'precinct', 'office', 'district', 'party', 'candidate', 'votes', 'election_day', 'provisional', 'absentee']:
	Row 2: ['Carbon', 'Banks Township', 'President', '', 'DEM', 'Voters Registered', '304', '304', '304', '304']
	Row 3: ['Carbon', 'Beaver Meadows Borough', 'President', '', 'DEM', 'Voters Registered', '192', '192', '192', '192']
	Row 4: ['Carbon', 'Bowmanstown Borough', 'President', '', 'DEM', 'Voters Registered', '181', '181', '181', '181']
	Row 5: ['Carbon', 'East Penn Township - North', 'President', '', 'DEM', 'Voters Registered', '285', '285', '285', '285']
	Row 6: ['Carbon', 'East Penn Township - South', 'President', '', 'DEM', 'Voters Registered', '282', '282', '282', '282']
	Row 22: ['Carbon', 'East Side Borough', 'President', '', 'DEM', 'Voters Registered', '61', '61', '61', '61']
	Row 23: ['Carbon', 'Franklin Township -Independent', 'President', '', 'DEM', 'Voters Registered', '214', '214', '214', '214']
	Row 24: ['Carbon', 'Franklin Township - Harrity', 'President', '', 'DEM', 'Voters Registered', '341', '341', '341', '341']
	Row 25: ['Carbon', 'Franklin Township - LongRun', 'President', '', 'DEM', 'Voters Registered', '273', '273', '273', '273']
	Row 26: ['Carbon', 'Jim Thorpe Borough -Second Ward', 'President', '', 'DEM', 'Voters Registered', '226', '226', '226', '226']
	[Truncated to 10 examples]

Copy link

Thank you for your contribution! Our vote_breakdown_totals test detected some potential issues in the files you added.

======================================================================
FAIL: test_vote_method_totals (data_tests.test_data.VoteBreakdownTotalsTest.test_vote_method_totals) [2024/20240423__pa__primary__blair__precinct.csv]
----------------------------------------------------------------------
There are 2 rows where the sum of ['election_day', 'provisional', 'absentee'] is greater than 'votes':

	Headers: ['county', 'precinct', 'office', 'district', 'party', 'candidate', 'votes', 'election_day', 'provisional', 'absentee']:
	Row 12087: ['Blair', 'Antis Twp 1', 'DELEGATE TO THE REPUBLICAN NATIONAL CONVENTION', '', 'REP', 'Total Votes Cast 1,', '049', '872', '0', '177']
	Row 24430: ['Blair', 'North Woodbury Twp', 'DELEGATE TO THE REPUBLICAN NATIONAL CONVENTION', '', 'REP', 'Total Votes Cast 1,', '296', '999', '0', '297']

Copy link

Thank you for your contribution! Our file_format test detected some potential issues in the files you added.

======================================================================
FAIL: test_format (data_tests.test_data.FileFormatTests.test_format) [2024/20240423__pa__primary__blair__precinct.csv]
----------------------------------------------------------------------
* There are 30178 rows that have entries with leading or trailing whitespace characters:

	Row 2: ['Blair', 'Altoona 1', 'President', '', 'DEM', 'Joseph R Biden Jr ', '46', '29', '0', '17']
	Row 3: ['Blair', 'Altoona 1', 'President', '', 'DEM', 'Dean Phillips ', '3', '3', '0', '0']
	Row 4: ['Blair', 'Altoona 1', 'President', '', 'DEM', 'Write-In Totals ', '3', '3', '0', '0']
	Row 5: ['Blair', 'Altoona 1', 'President', '', 'DEM', 'Write-In: Scattered ', '3', '3', '0', '0']
	Row 6: ['Blair', 'Altoona 1', 'President', '', 'DEM', 'Not Assigned ', '0', '0', '0', '0']
	Row 7: ['Blair', 'Altoona 1', 'President', '', 'DEM', 'Total Votes Cast ', '52', '35', '0', '17']
	Row 8: ['Blair', 'Altoona 1', 'U.S. Senate', '', 'DEM', 'Disqualifiied ', '11', '9', '0', '2']
	Row 9: ['Blair', 'Altoona 1', 'U.S. Senate', '', 'DEM', 'Robert P Casey Jr ', '42', '27', '0', '15']
	Row 10: ['Blair', 'Altoona 1', 'U.S. Senate', '', 'DEM', 'Write-In Totals ', '1', '1', '0', '0']
	Row 11: ['Blair', 'Altoona 1', 'U.S. Senate', '', 'DEM', 'Write-In: Scattered ', '1', '1', '0', '0']
	[Truncated to 10 examples]

@dwillis dwillis merged commit aa20dcf into openelections:master Aug 18, 2024
4 of 8 checks passed
@dwillis
Copy link
Contributor

dwillis commented Aug 18, 2024

Thanks, @declanrjb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants