Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): add openebs namespace in ci #580

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

sinhaashish
Copy link
Member

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?:
The Ci was failing

What this PR does?:
add namespce in ci

Does this PR require any upgrade changes?:
no

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/website is used to track them:

PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING

The PR title message must follow convention:
<type>(<scope>): <subject>.

Where:

  • type is defining if release will be triggering after merging submitted changes, details in CONTRIBUTING.md.
    Most common types are:

    • feat - for new features, not a new feature for build script
    • fix - for bug fixes or improvements, not a fix for build script
    • chore - changes not related to production code
    • docs - changes related to documentation
    • style - formatting, missing semi colons, linting fix etc; no significant production code changes
    • test - adding missing tests, refactoring tests; no production code change
    • refactor - refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changes
  • scope is a single word that best describes where the changes fit.
    Most common scopes are like:

    • data engine (localpv, jiva, cstor)
    • feature (provisioning, backup, restore, exporter)
    • code component (api, webhook, cast, upgrade)
    • test (tests, bdd)
    • chores (version, build, log, travis)
  • subject is a single line brief description of the changes made in the pull request.
    Fixes CI fails  #579

@sinhaashish sinhaashish force-pushed the rectify-ci branch 8 times, most recently from 76bc9e1 to 92b6826 Compare August 30, 2024 06:09
niladrih
niladrih previously approved these changes Aug 30, 2024
@sinhaashish sinhaashish force-pushed the rectify-ci branch 2 times, most recently from 8c074c7 to 7f01850 Compare August 30, 2024 06:34
@sinhaashish sinhaashish force-pushed the rectify-ci branch 2 times, most recently from 7461dd0 to 30ca493 Compare August 30, 2024 06:52
@Abhinandan-Purkait
Copy link
Member

Add the changes on the other workflow files, as we did for bdd job.

@sinhaashish
Copy link
Member Author

Add the changes on the other workflow files, as we did for bdd job.

Only added in the yaml files. addition of kubeconfig was erroring out as the ci test was not able to find the cluster

        env:
          OPENEBS_NAMESPACE: openebs

@niladrih niladrih dismissed their stale review August 30, 2024 07:30

I want to request more changes.

@niladrih
Copy link
Member

This is no longer required in the workflows, I think.

      - name: Setting environment variables
        run: |
          echo "KUBECONFIG=$HOME/.kube/config" >> $GITHUB_ENV
          echo "OPENEBS_NAMESPACE=openebs" >> $GITHUB_ENV

@sinhaashish
Copy link
Member Author

ci test was not able to find the cluster

after removing this ci test was not able to find the cluster

Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

      - name: Running tests
        env:
          OPENEBS_NAMESPACE: "openebs"
          KUBECONFIG: "~/.kube/config"

Also remove

      - name: Setting environment variables
        run: |
          echo "KUBECONFIG=$HOME/.kube/config" >> $GITHUB_ENV
          echo "OPENEBS_NAMESPACE=openebs" >> $GITHUB_ENV

Could you please try with these changes?

@sinhaashish sinhaashish force-pushed the rectify-ci branch 3 times, most recently from b9a382d to 7326357 Compare August 30, 2024 09:16
@Abhinandan-Purkait
Copy link
Member

Remove echo "OPENEBS_NAMESPACE=openebs" >> $GITHUB_ENV from the workflows.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (c389127) to head (57ce28a).
Report is 5 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #580   +/-   ##
========================================
  Coverage    96.37%   96.37%           
========================================
  Files            1        1           
  Lines          496      496           
========================================
  Hits           478      478           
  Misses          14       14           
  Partials         4        4           
Flag Coverage Δ
bddtests 96.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Abhinandan-Purkait Abhinandan-Purkait merged commit abaa59c into openebs:develop Aug 30, 2024
8 checks passed
@sinhaashish sinhaashish deleted the rectify-ci branch August 30, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI fails
4 participants