Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enhance build.yml workflow #565

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

Abhinandan-Purkait
Copy link
Member

@Abhinandan-Purkait Abhinandan-Purkait commented Jul 17, 2024

Workflow in detail

  • A user PR gets merged to the develop or release/x.y branch.
  • The concerned GitHub action workflow kicks in on the PR.
  • First, it checks out and sets up the runner.
  • It then runs the lint. Lints include helm lint.
  • Verify the chart version, it should be of the format x.y+1.0-develop or x.y.z-prerelease. If it’s anything else, the workflow fails.
  • Extract the chart version from the chart. This tag would be used for building the image locally.
  • Build the images using the code in the branch and tag it with x.y+1.0-develop or x.y.z-prerelease.
  • Set up the minikube cluster.
  • Execute the CI tests by installing the helm chart from the deploy/helm/charts directory. Set the image pull policy to Never since we are supposed to use the images built in the previous step.
  • Execute the CI tests. We are to use the helm chart here.
  • If the test passes the CI succeeds else it fails.
  • Push the images to the docker hub registry ?
  • Package the helm chart and push it to the gh-pages ?

NOTE

This PR removes the ansible step, that used to create image for e2e-test. e2e-test for openebs engines are now supposed to be carried out in the https://github.com/openebs/openebs-e2e repo going forward.

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.53%. Comparing base (1b43f65) to head (b06b0ed).
Report is 4 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #565   +/-   ##
========================================
  Coverage    99.53%   99.53%           
========================================
  Files            1        1           
  Lines          431      431           
========================================
  Hits           429      429           
  Misses           1        1           
  Partials         1        1           
Flag Coverage Δ
bddtests 99.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/pull_request.yml Outdated Show resolved Hide resolved
.github/workflows/pull_request_merge.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the release-charts changes come later?

.github/workflows/pull_request.yml Outdated Show resolved Hide resolved
.github/workflows/pull_request_merge.yml Outdated Show resolved Hide resolved
.github/workflows/pull_request_merge.yml Outdated Show resolved Hide resolved
@Abhinandan-Purkait Abhinandan-Purkait force-pushed the pr_merge branch 3 times, most recently from ce78d1e to cdb6114 Compare July 19, 2024 11:36
Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd have to document the removal of the ansible build and push e2e image on the PR description or commit message.

.github/workflows/build_and_push.yml Outdated Show resolved Hide resolved
Signed-off-by: Abhinandan Purkait <[email protected]>
@Abhinandan-Purkait Abhinandan-Purkait merged commit d4c1903 into openebs:develop Jul 22, 2024
7 checks passed
sinhaashish pushed a commit to sinhaashish/zfs-localpv that referenced this pull request Jul 24, 2024
ci: enhance build.yml workflow
Signed-off-by: sinhaashish <[email protected]>
@Abhinandan-Purkait Abhinandan-Purkait deleted the pr_merge branch July 26, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants