Skip to content

Commit

Permalink
fix(chart): move app=componentName label out of csi-node matchLabels
Browse files Browse the repository at this point in the history
The label `app: openebs-zfs-node` was missing on the csi-node components. However, adding it to the selector labels section breaks upgrade from previous versions.

This need not live in matchLabels, and could simply live in componentLabels

Signed-off-by: Niladri Halder <[email protected]>
  • Loading branch information
niladrih committed Dec 18, 2024
1 parent bc25af4 commit 380eb06
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deploy/helm/charts/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ Create labels for openebs zfs-localpv controller
Create match labels for openebs zfs-localpv node daemon
*/}}
{{- define "zfslocalpv.zfsNode.matchLabels" -}}
app: {{ .Values.zfsNode.componentName | quote }}
name: {{ .Values.zfsNode.componentName | quote }}{{ if or (not (hasKey .Values "enableHelmMetaLabels")) .Values.enableHelmMetaLabels }}
release: {{ .Release.Name }}
{{- end -}}
Expand All @@ -108,6 +107,7 @@ release: {{ .Release.Name }}
Create component labels openebs zfs-localpv node daemon
*/}}
{{- define "zfslocalpv.zfsNode.componentLabels" -}}
app: {{ .Values.zfsNode.componentName | quote }}
openebs.io/component-name: {{ .Values.zfsNode.componentName | quote }}
{{- end -}}

Expand Down

0 comments on commit 380eb06

Please sign in to comment.