Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add bucketization for usage #450

Merged
merged 2 commits into from
Oct 7, 2020
Merged

Add bucketization for usage #450

merged 2 commits into from
Oct 7, 2020

Conversation

yojs
Copy link
Contributor

@yojs yojs commented Oct 2, 2020

Fixes #: #449

Description of changes: Adds a way to create bucket calculators based on rca.conf settings. So say we want to add configurable bucket sizes for old-gen, so you add a new object to rca.conf (all three), something like this:

{
...
"bucketization": {
    "old-gen": {
      "UNDER_UTILIZED": ..,
      "HEALTHY_WITH_BUFFER": ..,
      "HEALTHY": ..
    }
}
...

The bucketCalculator hangs off the RcaConf and Deciders have access to RcaConf object. So, in order to bucketize the value, all a decider has to do is

rcaConf.getBucketizationSettings("old-gen").compute(<current-value>)

Tests: Added unit tests.

If new tests are added, how long do the new ones take to complete

  Test testCreateBucketAssigner PASSED (3.3s)
  Test testMisSpelledTunableName PASSED
  Test testNoThresholds PASSED
  Test testNoBucketizationSettings PASSED

SUCCESS: Executed 4 tests in 6.9s

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yojs
Copy link
Contributor Author

yojs commented Oct 3, 2020

Test nodeRoleChange FAILED (2s)

 429 tests completed, 1 failed
FAILURE: Executed 429 tests in 13m 41s (1 failed)

@yojs yojs requested review from sruti1312 and removed request for sidheart and rguo-aws October 5, 2020 19:42
Copy link
Contributor

@vigyasharma vigyasharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new comments from me, will wait for you to address @sruti1312's comments before approving.

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #450 into master will increase coverage by 0.25%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #450      +/-   ##
============================================
+ Coverage     72.00%   72.25%   +0.25%     
- Complexity     2630     2649      +19     
============================================
  Files           329      328       -1     
  Lines         14856    14902      +46     
  Branches       1238     1239       +1     
============================================
+ Hits          10697    10768      +71     
+ Misses         3758     3744      -14     
+ Partials        401      390      -11     
Impacted Files Coverage Δ Complexity Δ
...erformanceanalyzer/rca/framework/core/RcaConf.java 63.50% <77.77%> (+6.49%) 45.00 <7.00> (+7.00)
...rk/api/summaries/bucket/BasicBucketCalculator.java 95.00% <100.00%> (+1.66%) 9.00 <2.00> (+2.00)
...ceanalyzer/rca/framework/core/ConfJsonWrapper.java 94.87% <100.00%> (+0.27%) 21.00 <5.00> (+1.00)
...cisionmaker/actions/configs/CacheActionConfig.java 95.83% <0.00%> (-1.95%) 10.00% <0.00%> (+2.00%) ⬇️
...cisionmaker/actions/configs/QueueActionConfig.java 93.18% <0.00%> (-1.95%) 10.00% <0.00%> (+2.00%) ⬇️
...anceanalyzer/decisionmaker/deciders/Publisher.java 78.94% <0.00%> (-1.55%) 10.00% <0.00%> (-2.00%)
...nalyzer/decisionmaker/actions/CoolOffDetector.java
...yzer/rca/framework/api/summaries/ResourceUtil.java 98.50% <0.00%> (+0.32%) 4.00% <0.00%> (ø%)
...erformanceanalyzer/rca/scheduler/RCAScheduler.java 71.42% <0.00%> (+1.19%) 13.00% <0.00%> (+1.00%)
.../rca/store/rca/hotheap/HighHeapUsageOldGenRca.java 88.79% <0.00%> (+1.72%) 23.00% <0.00%> (+1.00%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc3b1bc...1c17d91. Read the comment docs.

@vigyasharma vigyasharma merged commit 5077a8a into master Oct 7, 2020
@yojs yojs deleted the bucketize branch October 7, 2020 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants