This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yojs
requested review from
sruti1312
and removed request for
sidheart and
rguo-aws
October 5, 2020 19:42
sruti1312
suggested changes
Oct 6, 2020
...ticsearch/performanceanalyzer/rca/framework/api/summaries/bucket/neo/BucketAssignerTest.java
Outdated
Show resolved
Hide resolved
src/test/resources/rca/bucketization/bucketize_no_thresholds.json
Outdated
Show resolved
Hide resolved
src/test/resources/rca/bucketization/bucketize_no_thresholds.json
Outdated
Show resolved
Hide resolved
...ticsearch/performanceanalyzer/rca/framework/api/summaries/bucket/neo/BucketAssignerTest.java
Show resolved
Hide resolved
...java/com/amazon/opendistro/elasticsearch/performanceanalyzer/rca/framework/core/RcaConf.java
Outdated
Show resolved
Hide resolved
vigyasharma
reviewed
Oct 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new comments from me, will wait for you to address @sruti1312's comments before approving.
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
============================================
+ Coverage 72.00% 72.25% +0.25%
- Complexity 2630 2649 +19
============================================
Files 329 328 -1
Lines 14856 14902 +46
Branches 1238 1239 +1
============================================
+ Hits 10697 10768 +71
+ Misses 3758 3744 -14
+ Partials 401 390 -11 Continue to review full report at Codecov.
|
sruti1312
approved these changes
Oct 7, 2020
vigyasharma
approved these changes
Oct 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #: #449
Description of changes: Adds a way to create bucket calculators based on rca.conf settings. So say we want to add configurable bucket sizes for old-gen, so you add a new object to
rca.conf
(all three), something like this:The bucketCalculator hangs off the
RcaConf
andDeciders
have access toRcaConf
object. So, in order to bucketize the value, all a decider has to do isrcaConf.getBucketizationSettings("old-gen").compute(<current-value>)
Tests: Added unit tests.
If new tests are added, how long do the new ones take to complete
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.