feature(pu): add alphazero ctree unittest #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
puyuan1996
commented
Dec 10, 2024
•
puyuan1996
commented
- add alphazero ctree unittest
- *_v0.py is backup files
PaParaZz1
requested changes
Dec 19, 2024
|
|
||
| sys.path.append('./LightZero/lzero/mcts/ctree/ctree_alphazero/build') | ||
|
|
||
| sys.path.append('/Users/puyuan/code/LightZero/lzero/mcts/ctree/ctree_alphazero/build') |
There was a problem hiding this comment.
path = os.path.joins(os.path.dirname(__file__), 'xxx'))
sys.path.append(path)| @@ -10,7 +10,9 @@ | |||
| update_per_collect = 50 | |||
| batch_size = 256 | |||
| max_env_step = int(2e5) | |||
| mcts_ctree = False | |||
| # mcts_ctree = False | |||
| mcts_ctree = True | |||
| @@ -220,7 +220,7 @@ def _init_collect(self) -> None: | |||
| self._collect_model = self._model | |||
| if self._cfg.mcts_ctree: | |||
| import sys | |||
| sys.path.append('/Users/your_user_name/code/LightZero/lzero/mcts/ctree/ctree_alphazero/build') | |||
| sys.path.append('/Users/puyuan/code/LightZero/lzero/mcts/ctree/ctree_alphazero/build') | |||
| @@ -0,0 +1,289 @@ | |||
| # ./lzero/mcts/ctree/ctree_alphazero/test/eval_alphazero_ctree_zh.py | |||
|
|
||
| class MockEnv: | ||
| """ | ||
| 一个简单的模拟环境类，包含必要的属性和方法。 |
| if (battle_mode_in_simulation_env == "self_play_mode") { | ||
| update(leaf_value); | ||
| if (!is_root()) { | ||
| if (!is_root() && parent) { |
There was a problem hiding this comment.
if a node is not the root node, its parent can't be null.
| void update_recursive(float leaf_value, std::string battle_mode_in_simulation_env) { | ||
| // If the mode is "self_play_mode", the leaf_value is subtracted from the parent's value | ||
| // 递归更新节点和父节点的值 | ||
| void update_recursive(float leaf_value, const std::string& battle_mode_in_simulation_env) { |
There was a problem hiding this comment.
why use const std::string&, add some comments
| children[action] = node; | ||
| // 获取子节点 | ||
| const std::map<int, std::shared_ptr<Node>>& get_children() const { | ||
| return children; | ||
| } | ||
|
|
||
| public: |
| self.assertFalse(parent.is_leaf(), "添加子节点后，父节点不应为叶子节点") | ||
|
|
||
|
|
||
| class TestMCTSAlphaZero(unittest.TestCase): |
There was a problem hiding this comment.
You should add a test method to validate its effectiveness on 50 simulations
| self.action_space = type('action_space', (), {'n': 3})() | ||
|
|
||
| def reset(self, start_player_index, init_state, katago_policy_init, katago_game_state): | ||
| """ |
There was a problem hiding this comment.
maybe you should reset something in the reset method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.