198 policy service issue with logical deletion in policy service leading to conflict on policy recreation #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielefantini
approved these changes
Dec 4, 2024
gabrielefantini
deleted the
198-policy-service-issue-with-logical-deletion-in-policy-service-leading-to-conflict-on-policy-recreation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes an issue in the policy service where duplicate name checks did not properly account for the
IS_LAST_VERSIONflag. Previously, the check would cause conflicts when recreating policies with the same names as logically deleted policies.Changes
IS_LAST_VERSION = true.Issue Addressed
Resolves the problem where attempting to create a policy with the same name as a logically deleted one would result in an error.
Testing