Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for warnings from PF upgrade #3588

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeff-phillips-18
Copy link
Contributor

Closes RHOAIENG-16464

Description

Fix for warnings in the console cause by PF v6 upgrade.

How Has This Been Tested?

  • Navigate to Applications -> Explore

  • Open the dev console, verify there are no warnings generated

  • Navigate to Settings -> Accelerator profiles

  • Open the dev console, verify there are no warnings generated

Test Impact

Test Id was updated from description to table-row-title-description
No additional tests required since there is merely a structural change.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jeff-phillips-18
Copy link
Contributor Author

/cc @manosnoam Please note the test id change mentioned above

@openshift-ci openshift-ci bot requested a review from manosnoam December 18, 2024 12:46
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@jeff-phillips-18: GitHub didn't allow me to request PR reviews from the following users: note, the, id, change, above, test, Please.

Note that only opendatahub-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @manosnoam Please note the test id change mentioned above

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@christianvogt
Copy link
Contributor

@jeff-phillips-18 both warnings mentioned in the linked issue are still present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants