Remove invalid jump link

[ashley-o0o]

Closes: RHOAIENG-16189

Description

Removes invalid jump link to Data connections in the create workbench page. In doing so, also cleaned up some unused data connections code.

How Has This Been Tested?

Tested locally on cluster.

• Navigate to your data science project
• Workbench tab, create workbench.
• The Data connections jump link should no longer exist.

Test Impact

No tests changed

Screenshots

Before:

After:

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.17%. Comparing base (6ac8b17) to head (714da2a).
Report is 51 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3559      +/-   ##
==========================================
- Coverage   85.54%   85.17%   -0.37%     
==========================================
  Files        1371     1382      +11     
  Lines       31190    31571     +381     
  Branches     8731     8824      +93     
==========================================
+ Hits        26680    26892     +212     
- Misses       4510     4679     +169     

Files with missing lines	Coverage Δ
...src/pages/projects/screens/spawner/SpawnerPage.tsx	86.72% <100.00%> (ø)
...ontend/src/pages/projects/screens/spawner/const.ts	100.00% <ø> (ø)
...ontend/src/pages/projects/screens/spawner/types.ts	100.00% <ø> (ø)

... and 318 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac8b17...714da2a. Read the comment docs.

[christianvogt]

@ashley-o0o

It's ok to remove the the Data connections jump link however you're also removing tests which should stay until we convert the same to work work connection types.

Instead of trying to do the clean up of data connections here, we should keep the code around until we tackle the story to remove it so that we can update tests at the same time.

[ashley-o0o]

@christianvogt okay I'll restore the test. Would you like me to comment that part out then? Otherwise the tests fail.

[christianvogt]

@ashley-o0o the test should not fail if all you're doing is removing the jump link

[christianvogt]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[christianvogt]

/retest