-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename component_metadata.yaml to use the Red hat build of prefix #762
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/762/head
git checkout -b pullrequest 272fdff1a957f2064b07c97a75ea2af974db72cb
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-762" More instructions here on how to deploy and test a Data Science Pipelines Application. |
Signed-off-by: Ricardo M. Oliveira <[email protected]>
Change to PR detected. A new PR build was completed. |
@@ -1,4 +1,4 @@ | |||
releases: | |||
- name: Kubeflow Pipelines | |||
- name: Red Hat build of Kubeflow Pipelines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So repoUrl is pointed to KFP, not DSP, so would this make the metadata misleading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be fine IMO, since we specifically mention it as a build of KFP.
The issue resolved by this Pull Request:
As discussed with other teams, they decided to add a preffix
Red Hat build of
preffix in the upstream project name.Description of your changes:
Testing instructions
Checklist