Bump dependencies of packages. Migrating from Pydantic v1 to v2 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyNenashev
requested changes
Apr 16, 2024
| # //postgresql/host/my.host.com:5432/databases/database_name/schemas/schema_name/tables/another_table_name/relationships/references_table_2_with_constraint_fk | ||
|
|
||
| # you can get path wih new values: | ||
| oddrn_gen.get_oddrn_by_path("tables_columns", new_value="another_new_column_name") | ||
| print(oddrn_gen.get_oddrn_by_path("tables_columns", new_value="another_new_column_name")) |
oddrn_generator/path_models.py
Outdated
Comment on lines
101
to
103
| dependencies_map: dict = Field( | ||
| default_factory=lambda: MysqlPathsModel._dependencies_map_factory() | ||
| ) |
There was a problem hiding this comment.
Suggested change
| dependencies_map: dict = Field( | |
| default_factory=lambda: MysqlPathsModel._dependencies_map_factory() | |
| ) | |
| dependencies_map: dict = Field( | |
| default_factory=MysqlPathsModel._dependencies_map_factory | |
| ) |
There was a problem hiding this comment.
just in case If you would like to elaborate type hint usage in python you can do something like this
Suggested change
| dependencies_map: dict = Field( | |
| default_factory=lambda: MysqlPathsModel._dependencies_map_factory() | |
| ) | |
| DependenciesMap = Dict[str, Tuple[str, ...]] | |
| ... | |
| dependencies_map: DependenciesMap = Field( | |
| default_factory=MysqlPathsModel._dependencies_map_factory | |
| ) |
oddrn_generator/path_models.py
Outdated
Comment on lines
113
to
115
| dependencies_map: dict = Field( | ||
| default_factory=lambda: KafkaPathsModel._dependencies_map_factory() | ||
| ) |
There was a problem hiding this comment.
Suggested change
| dependencies_map: dict = Field( | |
| default_factory=lambda: KafkaPathsModel._dependencies_map_factory() | |
| ) | |
| dependencies_map: dict = Field( | |
| default_factory=KafkaPathsModel._dependencies_map_factory | |
| ) |
oddrn_generator/path_models.py
Outdated
Comment on lines
125
to
127
| dependencies_map: dict = Field( | ||
| default_factory=lambda: KafkaConnectorPathsModel._dependencies_map_factory() | ||
| ) |
There was a problem hiding this comment.
Suggested change
| dependencies_map: dict = Field( | |
| default_factory=lambda: KafkaConnectorPathsModel._dependencies_map_factory() | |
| ) | |
| dependencies_map: dict = Field( | |
| default_factory=KafkaConnectorPathsModel._dependencies_map_factory | |
| ) |
oddrn_generator/path_models.py
Outdated
Comment on lines
149
to
151
| dependencies_map: dict = Field( | ||
| default_factory=lambda: GluePathsModel._dependencies_map_factory() | ||
| ) |
There was a problem hiding this comment.
Suggested change
| dependencies_map: dict = Field( | |
| default_factory=lambda: GluePathsModel._dependencies_map_factory() | |
| ) | |
| dependencies_map: dict = Field( | |
| default_factory=GluePathsModel._dependencies_map_factory | |
| ) |
oddrn_generator/path_models.py
Outdated
Comment on lines
178
to
180
| dependencies_map: dict = Field( | ||
| default_factory=lambda: SnowflakePathsModel._dependencies_map_factory() | ||
| ) |
There was a problem hiding this comment.
Suggested change
| dependencies_map: dict = Field( | |
| default_factory=lambda: SnowflakePathsModel._dependencies_map_factory() | |
| ) | |
| dependencies_map: dict = Field( | |
| default_factory=SnowflakePathsModel._dependencies_map_factory | |
| ) |
oddrn_generator/path_models.py
Outdated
Comment on lines
196
to
198
| dependencies_map: dict = Field( | ||
| default_factory=lambda: AirflowPathsModel._dependencies_map_factory() | ||
| ) |
There was a problem hiding this comment.
Suggested change
| dependencies_map: dict = Field( | |
| default_factory=lambda: AirflowPathsModel._dependencies_map_factory() | |
| ) | |
| dependencies_map: dict = Field( | |
| default_factory=AirflowPathsModel._dependencies_map_factory | |
| ) |
AndreyNenashev
approved these changes
Apr 16, 2024
RamanDamayeu
approved these changes
Apr 16, 2024
ValeriyWorld
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.