-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(load) : with "auto" chunks and type specified #181 #182
Conversation
for more information, see https://pre-commit.ci
aba9ee6
to
0aec7b7
Compare
Preparing release v0.3.11
for more information, see https://pre-commit.ci
Preparing release v0.3.11
…x/autochunks_dtype
Hy there. Can someone make a feedback ? Thanks for your work 🤗 |
@nkarasiak thank you for the contribution, but I have to ask you to undo all the formatting changes please, and also rebase your history into a cleaner set of commits, 21 commits for fixing 3 problems is too many commits. Ideally I'd like to see only changes related to the fix present in the PR. This repo uses Right now we are in process of splitting |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #182 +/- ##
===========================================
+ Coverage 87.58% 91.54% +3.95%
===========================================
Files 23 24 +1
Lines 1982 2850 +868
===========================================
+ Hits 1736 2609 +873
+ Misses 246 241 -5 ☔ View full report in Codecov by Sentry. |
Hello @Kirill888, Thank you for the feedback and for the explanation on how to improve my contribution. That seems really obvious when you explain it ! I'll do that in two weeks. |
for more information, see https://pre-commit.ci
Preparing release v0.3.11
This reverts commit 647eb8d.
This reverts commit 02bd1dd.
…x/autochunks_dtype
…x/autochunks_dtype
I close this pull request, too much drafts. |
Fixes issue #181 #184 and #183