Rename deprecated pystac_client methods to get STAC items and collections

[weiji14]

These methods were deprecated since stac-utils/pystac-client#206 in pystac_client v0.4.0 (released Jun 2022):

• get_items() -> items()
• get_all_items() -> item_collection()
• get_all_items_as_dict() -> item_collection_as_dict()

This helps to silence the following warnings:

/srv/conda/envs/notebook/lib/python3.10/site-packages/pystac_client/item_search.py:834: FutureWarning: get_items() is deprecated, use items() instead
  warnings.warn(

/srv/conda/envs/notebook/lib/python3.10/site-packages/pystac_client/item_search.py:849: FutureWarning: get_all_items() is deprecated, use item_collection() instead.
  warnings.warn(

/srv/conda/envs/notebook/lib/python3.10/site-packages/pystac_client/item_search.py:864: FutureWarning: get_all_items_as_dict() is deprecated, use item_collection_as_dict() instead.
  warnings.warn(

.

[Kirill888]

Thanks for that @weiji14 do you mind checking if these bounds are still valid after the change?

odc-stac/setup.cfg

Line 46 in 34e5539

pystac>=1.0.0,<2

[weiji14]

The requirement on pystac>=1.0.0,<2 isn't directly related to the changes here (which are on pystac-client).

That said, using pystac>=1.0.0 means supporting STAC 1.0.x, and pystac-client=0.4.0 where this API change was introduced supports pystac>=1.4.0 according to https://github.com/stac-utils/pystac-client/blob/v0.4.0/setup.py#L36, so I think it should be fine.