[feat]tools-v2: add bs create volume snapshot #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cicheck |
1 similar comment
|
cicheck |
Cyber-SiKu
reviewed
Sep 26, 2023
tools-v2/pkg/cli/command/curvebs/create/volume/snapshot/snapshot.go
Outdated
Show resolved
Hide resolved
baytan0720
force-pushed
the
create_volume_snapshot
branch
from
a5e0878 to
448e3f1
Compare
|
cicheck |
1 similar comment
|
cicheck |
Cyber-SiKu
approved these changes
Sep 28, 2023
baytan0720
force-pushed
the
create_volume_snapshot
branch
from
448e3f1 to
067f655
Compare
|
cicheck |
2 similar comments
|
cicheck |
|
cicheck |
baytan0720
force-pushed
the
create_volume_snapshot
branch
from
067f655 to
cd28014
Compare
|
cicheck |
1 similar comment
|
cicheck |
2 tasks
|
@baytan0720 need to rebase. |
baytan0720
force-pushed
the
create_volume_snapshot
branch
2 times, most recently
from
2a4e051 to
0786363
Compare
Signed-off-by: baytan0720 <[email protected]>
baytan0720
force-pushed
the
create_volume_snapshot
branch
from
0786363 to
b762c43
Compare
|
cicheck |
|
cicheck |
1 similar comment
|
cicheck |
|
@caoxianfei1 PTAL |
caoxianfei1
reviewed
Dec 12, 2023
|
|
||
| Usage: | ||
| ```bash | ||
| curve bs create volume snapshot --user root --filename test --snapshotname snap-test |
There was a problem hiding this comment.
The filename is '/test'?
caoxianfei1
reviewed
Dec 12, 2023
| metric := basecmd.NewMetric(sCmd.snapshotAddrs, subUri, sCmd.timeout) | ||
| result, err := basecmd.QueryMetric(metric) | ||
| if err.TypeCode() != cmderror.CODE_SUCCESS { | ||
| return err.ToError() |
There was a problem hiding this comment.
we should get error code and return proper error description?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2585
Problem Summary:
What is changed and how it works?
What's Changed:
modify tools-v2/internal/utils/snapshot.go
modify tools-v2/internal/utils/row.go
modify tools-v2/pkg/cli/command/curvebs/create/create.go
modify tools-v2/pkg/config/bs.go
add tools-v2/pkg/cli/command/curvebs/create/volume/snapshot/snapshot.go
add tools-v2/pkg/cli/command/curvebs/create/volume/volume.go
How it Works:
Usage:
curve bs create volume snapshot --user root --filename test --snapshotname snap-testOutput:
Side effects(Breaking backward compatibility? Performance regression?):
Check List