Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat]tools-v2: add bs update volume flatten #2757

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[feat]tools-v2: add bs update volume flatten #2757

merged 1 commit into from
Oct 10, 2023

Conversation

baytan0720
Copy link
Member

What problem does this PR solve?

Issue Number: #2587

Problem Summary:

add bs update volume flatten

What is changed and how it works?

What's Changed:

modify tools-v2/pkg/cli/command/base.go
create tools-v2/pkg/cli/command/curvebs/update/volume/volume.go
create tools-v2/pkg/cli/command/curvebs/update/volume/flatten/flatten.go

How it Works:

Usage:

curve bs update volume flatten

Output:

+------+--------------------------------------+---------+            
| USER |               TASK ID                | RESULT  |            
+------+--------------------------------------+---------+            
| root | d26e27a8-fcbd-4f7a-adf8-53795217cbb0 | success |            
+------+--------------------------------------+---------+

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@baytan0720 baytan0720 force-pushed the update_volume_flatten branch 5 times, most recently from 933eda5 to 3ff9e1e Compare September 20, 2023 09:30
@baytan0720
Copy link
Member Author

cicheck

1 similar comment
@baytan0720
Copy link
Member Author

cicheck

@baytan0720 baytan0720 force-pushed the update_volume_flatten branch from 3ff9e1e to 7c4c6f1 Compare September 21, 2023 10:23
@baytan0720
Copy link
Member Author

cicheck

2 similar comments
@baytan0720
Copy link
Member Author

cicheck

@baytan0720
Copy link
Member Author

cicheck

@baytan0720 baytan0720 force-pushed the update_volume_flatten branch from 7c4c6f1 to d5769c3 Compare September 23, 2023 15:46
@baytan0720
Copy link
Member Author

cicheck

1 similar comment
@baytan0720
Copy link
Member Author

cicheck

Cyber-SiKu
Cyber-SiKu reviewed Sep 26, 2023
View reviewed changes
tools-v2/pkg/cli/command/curvebs/update/volume/flatten/flatten.go Outdated
row[cobrautil.ROW_USER] = fCmd.user
row[cobrautil.ROW_TASK_ID] = fCmd.taskID

if payload["Code"] != "0" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defined as constant

@baytan0720 baytan0720 force-pushed the update_volume_flatten branch from d5769c3 to 3dc530c Compare October 8, 2023 13:07
@baytan0720
Copy link
Member Author

cicheck

6 similar comments
@baytan0720
Copy link
Member Author

cicheck

@baytan0720
Copy link
Member Author

cicheck

@baytan0720
Copy link
Member Author

cicheck

@baytan0720
Copy link
Member Author

cicheck

@baytan0720
Copy link
Member Author

cicheck

@baytan0720
Copy link
Member Author

cicheck

@baytan0720 baytan0720 closed this Oct 9, 2023
@baytan0720 baytan0720 reopened this Oct 9, 2023
@baytan0720
Copy link
Member Author

cicheck

@baytan0720 baytan0720 mentioned this pull request Oct 9, 2023
Closed
@baytan0720 baytan0720 requested a review from Cyber-SiKu October 10, 2023 01:00
@caoxianfei1 caoxianfei1 merged commit 505cc7a into opencurve:master Oct 10, 2023
3 checks passed
@baytan0720 baytan0720 deleted the update_volume_flatten branch November 3, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caoxianfei1 caoxianfei1 caoxianfei1 approved these changes

@Cyber-SiKu Cyber-SiKu Cyber-SiKu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baytan0720 @Cyber-SiKu @caoxianfei1