Add occupancy and watermark counters in cells #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add occcupancy and watermark counters for priority group and queue objects in shared buffer cells to report them as they are in counted in the ASIC. Also add a companion read-only attribute to get the cell size of a shared buffer in a switch. Signed-off-by: Marian Pritsak <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@vmittal-msft - FYI |
|
kcudnik
approved these changes
Nov 19, 2024
r12f
reviewed
Dec 23, 2024
| SAI_INGRESS_PRIORITY_GROUP_STAT_CURR_OCCUPANCY_CELLS = 0x00000009, | ||
|
|
||
| /** Get watermark pg occupancy in cells [uint64_t] */ | ||
| SAI_INGRESS_PRIORITY_GROUP_STAT_WATERMARK_CELLS = 0x0000000a, |
There was a problem hiding this comment.
Hi Marian, just a sanity checks here, do we need:
- SAI_INGRESS_PRIORITY_GROUP_STAT_XOFF_ROOM_CURR_OCCUPANCY_CELLS
- SAI_INGRESS_PRIORITY_GROUP_STAT_XOFF_ROOM_WATERMARK_CELLS
For SAI_INGRESS_PRIORITY_GROUP_STAT_BYTES, I believe it is supported, and we don't need the cell counts (as it will be bad for tracking the traffic volume).
There was a problem hiding this comment.
are we missing the buffer pool ones? or can they be supported in bytes?
| SAI_QUEUE_STAT_CURR_OCCUPANCY_CELLS = 0x00000028, | ||
|
|
||
| /** Get watermark queue occupancy in cells [uint64_t] */ | ||
| SAI_QUEUE_STAT_WATERMARK_CELLS = 0x00000029, |
There was a problem hiding this comment.
same here, do we need SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_CELLS?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add occcupancy and watermark counters for
priority group and queue objects in shared buffer cells to report them as they are in counted in the ASIC. Also add a companion read-only attribute to
get the cell size of a shared buffer in a switch.