[DASH] Update dash headers to most recent #1832
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marian-pritsak, @Pterosaur, @chrispsommers please review |
|
Please reference the exact commit ID of DASH which these headers were generated from, |
|
commit generated sonic-net/DASH@b6d44c7 |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
| * @type sai_uint32_t | ||
| * @flags MANDATORY_ON_CREATE | CREATE_ONLY | ||
| */ | ||
| SAI_DASH_ACL_RULE_ATTR_DST_TAG, |
There was a problem hiding this comment.
ACL tags should be removed from the SAI API. Recently DASH WG decided to remove ACL tags from the SAI requirements
There was a problem hiding this comment.
i don't follow exactly what rules are for acl, i just generated headers from DASH repo and just added here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates DASH experimental headers to headers generated from https://github.com/sonic-net/DASH repo on origin/main