-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement UserMap and GroupMap output. #159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for PosixMapperClient, you can already get the whole list by querying with an empty arg list so I thought we considered those iterator methods to be convenience that we didn't need (because the init container would just hit the URL itself and not involve java code). What's the use cases for adding this other than iterator is more scalable?
aside: the CADC/CANFAR uidmap is 250KiB and the gidmap is 375KiB
as for the other change, I don't know that preferred_username
is really spec compliant. That is one of the discrepancies between IAM and Rubin/LSST, which also claim OIDC complaince. So I'm not sure what that is fixing exactly... is it supposed to make ac
more OIDC compliant than it is?
These things sometimes need to be discussed before working on them
The comments of the As for adding the Plus it lines up with the SKAO IAM service, and what openid.net suggests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PosixMapperClient work looks fine, but I should have defined the API using ResourceIterator instead of Iterator (so the underlying input stream close() gets called).
Can you make that improvement and remove the changes from cadc-access-control-server?
Alright, that's complete now. |
Fixes #158