Features/versioning and flags #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russbiggs
reviewed
Oct 9, 2024
openaq_api/openaq_api/middleware.py
Outdated
| requests_used = value | ||
|
|
||
| response.headers["x-ratelimit-limit"] = str(limit) | ||
| response.headers["x-ratelimit-remaining"] = "0" |
There was a problem hiding this comment.
This shouldnt be hardcoded to "0", needs to be dynamic showing the remaining number of requests
openaq_api/openaq_api/middleware.py
Outdated
| return False | ||
|
|
||
|
|
||
| async def check_api_key( |
There was a problem hiding this comment.
Although this is acting like middleware still, We should move it to a new file called dependencies? I would like the middleware to all be ASGI middleware which this no longer is
openaq_api/openaq_api/middleware.py
Outdated
| @@ -21,6 +25,118 @@ | |||
|
|
|||
| logger = logging.getLogger("middleware") | |||
|
|
|||
| NOT_AUTHENTICATED_EXCEPTION = HTTPException( | |||
There was a problem hiding this comment.
Lets put these in either the v3/models/responses.py or a separate exceptions.py file
There was a problem hiding this comment.
Added exceptions file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates required for CAC work