maintenance release workflow #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasaplus1
commented
Jul 19, 2023
| steps: | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| fetch-depth: 0 | ||
| - uses: actions/setup-node@v2-beta | ||
| - uses: actions/setup-node@v3 |
sasaplus1
commented
Jul 19, 2023
| @@ -15,39 +15,37 @@ jobs: | |||
| releasing: | |||
| name: releasing | |||
| runs-on: ubuntu-latest | |||
| timeout-minutes: 10 | |||
sasaplus1
commented
Jul 19, 2023
Comment on lines
+25
to
+27
| node-version: 18 | ||
| cache: npm | ||
| registry-url: 'https://registry.npmjs.org' |
There was a problem hiding this comment.
- バージョン上げ
- キャッシュを使う
.npmrcの設定をsetup-nodeにさせる
There was a problem hiding this comment.
nodeバージョン上げてますしリリースフロー確認がてらリリースしますか・・:eyes:
sasaplus1
commented
Jul 19, 2023
Comment on lines
+30
to
+31
| git config --global user.name 'github-actions[bot]' | ||
| git config --global user.email '41898282+github-actions[bot]@users.noreply.github.com' |
There was a problem hiding this comment.
GitHub Actions のアカウントとして設定する（と、見た目がカッコイイ）
sasaplus1
commented
Jul 19, 2023
sasaplus1
commented
Jul 19, 2023
Comment on lines
+44
to
+49
| gh pr create | ||
| --assignee | ||
| --base "${{ github.event.repository.default_branch }}" | ||
| --body '' | ||
| --head "${{ github.ref_name }}" | ||
| --title "chore(release): publish" |
There was a problem hiding this comment.
curlで頑張ってPOSTするよりかは現代ではghがあるのでそれを使う
https://github.com/peter-evans/create-pull-request を使うのでもよかったかもしれない
sasaplus1
commented
Jul 28, 2023
Comment on lines
+18
to
+21
| permissions: | ||
| contents: write | ||
| id-token: write | ||
| pull-requests: write |
There was a problem hiding this comment.
#93 (comment) により追加しました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release のワークフローも古かったので直しました。release のワークフローは頻繁に試せるわけでないので修正後にきちんと動作するのかは少し不安ではあるのですが……