Restructure tests #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename _set_mock_data to _test_issue_reminder (before the name suggested that it was only setting mock data) - Use named params. The `params` array was a bit hard to read, and the different length with the differing item inserted somewhere in the middle instead of the end made the code needlessly confusing. Also it contained unnecessary data - Both test_automatic_priority_on_issue and test_issue_with_low_priority_never_change now assert the complete list of function calls
|
Martchus
approved these changes
May 18, 2024
okurz
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paramsarray was a bit hard to read, and the different length with the differing item inserted somewhere in the middle instead of the end made the code needlessly confusing. Also it contained unnecessary data